Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Short Name as admin settings field alongside Site Title #210

Closed
westonruter opened this issue Aug 7, 2019 · 7 comments · Fixed by #691
Closed

Add Short Name as admin settings field alongside Site Title #210

westonruter opened this issue Aug 7, 2019 · 7 comments · Fixed by #691
Assignees
Milestone

Comments

@westonruter
Copy link
Collaborator

The web app manifest removed the short_name because it was not reliable to automatically generate: #201

In order to avoid a site having to add a web_app_manifest filter to supply the short_name, what if a new Short Name field is added after the Site Title:

image

This field could be hidden until the Site Title field has more than 12 characters in it.

@iandunn
Copy link
Collaborator

iandunn commented Aug 13, 2019

🤔

My first instinct is that it's not worth adding an extra option for this, but I do like your idea about hiding the field if the name is < 12 characters.

I'd probably still lean towards requiring devs to use a filter or something though, or letting a plugin add that field, rather than putting it in Core though.

@AdelDima
Copy link

AdelDima commented Dec 3, 2019

I agree with @iandunn, for me, I added a short name and name on Customizer settings, this way theme/plugin user can find all PWA options in one place for more simplicity.

Screen Shot on 2019-12-03 at 15-40-13

@westonruter
Copy link
Collaborator Author

westonruter commented Apr 10, 2020

Here's a prototype mini plugin which implements this Short Name UI on the general settings screen: https://gist.github.com/westonruter/dec7d190060732e29a09751ab99cc549

image

@westonruter
Copy link
Collaborator Author

This issue comes up over and over again in the support forums, so clearly there needs to be a UI to manage this. I'm adding it to the 0.7 milestone.

@westonruter westonruter self-assigned this Feb 8, 2022
@westonruter westonruter added the p0 label Feb 8, 2022
@pooja-muchandikar
Copy link

pooja-muchandikar commented Apr 19, 2022

QA Passed ✅

  • Short Name filed is available in General Settings

Screenshot 2022-04-19 at 12 47 26 PM


  • If Site title is lengthy then short name is displayed on phone's Add to home screen
    20220419_124918

  • If Short Name filter is added via plugin then the field appears disabled

Screenshot 2022-04-19 at 12 37 45 PM


  • If Shortname is added then site health screen shows it as passed

Screenshot 2022-04-19 at 12 59 06 PM


  • If short name is not added then site health shows error and a link general settings to add short name

Screenshot 2022-04-19 at 12 58 24 PM


@morsssss
Copy link

+1 to adding this new field. My WP experience is limited, but I'm helping a local news site called "Montclair Local" to make some fixes to their brand new site. The plugin shortened the name to "MntclrLclNws". I realized this plugin was generating the web app manifest, I found and installed Weston's helpful gist, and I fixed the name. Many others would never figure out how to do this.

@westonruter
Copy link
Collaborator Author

@morsssss This should be available the latest version of the plugin, so I don't think you need the gist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants