This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
fix: support legal comments #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Oct 19, 2023
packages/critters/src/index.js
Outdated
| @@ -477,7 +477,14 @@ export default class Critters { | |||
| ast, | |||
| markOnly((rule) => { | |||
| if (rule.type === 'comment') { | |||
| const comment = rule.text.trim(); | |||
| let comment = rule.text; | |||
There was a problem hiding this comment.
NIT: The following should be more performant.
const crittersComment = rule.text.match(/^!? ?critters:(.*)/);
const command = crittersComment && crittersComment[1];Removes the need for multiple .startsWith, .trim .slice, and .replace and also reduces memory allocation.
JeanMeche
force-pushed
the
support-legal-comments
branch
from
231d713 to
27446ff
Compare
JeanMeche
force-pushed
the
support-legal-comments
branch
from
27446ff to
6d5072f
Compare
|
There are some tests failing. Good to merge after they are fixed |
JeanMeche
force-pushed
the
support-legal-comments
branch
from
6d5072f to
afb2157
Compare
|
@janicklas-ralph We should be good now. |
janicklas-ralph
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular CLI would like to support
crittersin legal comments. Legal comments have a leading!and aren't removed at build times.Cf https://esbuild.github.io/api/#legal-comments
cc @alan-agius4