Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return meaningful response status for webhook error #13

Open
devnook opened this issue Apr 14, 2022 · 0 comments
Open

Return meaningful response status for webhook error #13

devnook opened this issue Apr 14, 2022 · 0 comments
Assignees

Comments

@devnook
Copy link
Contributor

devnook commented Apr 14, 2022

Instead of always returning an HTTP 200 in /approvals handler, we should propagate some errors that come from handling the webhook and use those to trigger an error response whose body contains details about the failure.

https://docs.github.com/en/github-ae@latest/rest/guides/best-practices-for-integrators#use-appropriate-http-status-codes-when-responding-to-github makes it sound like including errors about the failure in the response body could be helpful in debugging.

context: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant