-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation changes for v5 #2122
Comments
can i see the docs somewhere online? |
During the pre-release process, the best way to stay informed is to read each release's notes: https://github.com/GoogleChrome/workbox/releases We're not going to update the official docs until the final release of v5. |
@jeffposnick do you plan to work on migration documentation, now that rc0 is out? I would like to try v5, but I'm not sure to understand what needs to be changed from my v4 code. |
Hi Jeff, I'm in the progress of overhauling my service worker setup for a Sapper project (read Svelte) which ships a service worker. Now I've been looking at which ways to go forward and decided I want to give workbox a try. From the links above I figured that the current docs are all v4 and that a bunch of things will be different in v5, most notably the importScript vs bundler starting point. I'll need that documented in order to understand what to do exactly. Because of that I'll want to wait until the v5 docs are available. In order plan the next four or so weeks, can you give a rough estimate when this will be the case? one month? six month? |
@evdama, if you want a starting point, here's a sample project that uses Svelte and Workbox v5, with Rollup bundling the service worker and then For folks who decide that they want to use v5 early, the main difference when switching from the CDN to consuming the bundles is that anything that used to look like
now looks like
(This existing guide covers some of that in more detail, but it will also need to be updated for v5.) There are some renamings that happened between v4 and v5, specifically around the various
has a v5 equivalent of
And there a number of more involved changes to the build tools, especially the webpack plugin. v5 is currently feature complete, and we've ironed out a couple of bugs since entering the release candidate phase. The last remaining task before making v5 final is doing the documentation overhaul, and as per your question, it's going to be something much closer to 1 month than 6 months for that. |
We're going to be checking in changes to the (The handwritten Workbox docs live in a different repo.) You can follow along there. |
Thanks a lot for the pointer... Maybe either that page could get a little additon for how it's done using workbox, or, as an alternative, there could be a recipe example in the workbox docs about how you'd use workbox with firebase auth? |
@evdama That's interesting—I hadn't seen those Firebase docs before. It sounds like the sort of thing that would be best accomplished via a custom Workbox plugin for Firebase Auth. Let's track this request separately from the main v5 docs issue. |
Thanks for everyone's patience as we continue to work on the docs. The first draft of the v4 to v5 Migration Guide is now checked in. If you've been holding off on trying the v5 pre-releases until that guidance was available, please take a look! |
What's the upgrade path for something like new WorkboxPlugin.InjectManifest({
swSrc: "src/sw.js",
globDirectory: "../site/",
globPatterns: ["404.html", "offline.html", "assets/fonts/**/*", "assets/webfonts/**/*", "assets/icons/*"]
}), |
A couple of options:
Option 1 is probably the most " Option 2 is fairly easy to implement. Option 3 is the most involved, but gives you the most control. |
This is a master tracking issue for documentation changes we need to make along with releasing v5. We can update this issue as new breaking changes are introduced.
makeRequest
method is not longer supported on strategy classes (docs page)registerNavigationRoute
is gone, and this docs page needs to be updated, along with a new recipe geared to the App Shell use case.integrity
field in the precache manifest.workbox-broadcast-update
docs to point out it no longer uses theBroadcastChannel
API (and that it works in all browsers).revision: null
and the eventual deprecation ofstring
parameters in theworkbox-precaching
guide.workbox-sw
module page as an alternative.workbox-navigation-preload
.The text was updated successfully, but these errors were encountered: