This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Fix #1630 #1660
Merged
Fix #1630 #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for web-dev-staging ready! Built with commit 23b0dd5 |
10 tasks
|
@paulirish can you review this? |
paulirish
reviewed
Oct 29, 2019
| web_lighthouse: | ||
| - first-cpu-idle | ||
| --- | ||
|
|
||
| {% Aside 'caution' %} | ||
| First CPU Idle is deprecated in Lighthouse 6.0. First CPU Idle |
There was a problem hiding this comment.
something along these lines would be dope
First CPU Idle is deprecated in Lighthouse 6.0. While some have found that First CPU Idle offers a
more meaningful timestamp than [Time To Interactive](/interactive), the difference isn't significant
enough to justify maintaining two similar metrics.
Moving forward, look at [Total Blocking Time](/lighthouse-total-blocking-time/) and [Time To Interactive](/interactive).| web_lighthouse: | ||
| - first-meaningful-paint | ||
| --- | ||
|
|
||
| {% Aside 'caution' %} | ||
| First Meaningful Paint (FMP) is deprecated in Lighthouse 6.0. In practice FMP |
There was a problem hiding this comment.
here's what i got
First Meaningful Paint (FMP) is deprecated in Lighthouse 6.0. In practice FMP
has been overly sensitive to small differences in the page load, leading to inconsistent (bimodal) results. Additionally, the metric's definition relies on browser-specific implementation details, which means it cannot be standardized nor be implemented in all web browsers.
Moving forward, consider [Largest Contentful Paint](/largest-contentful-paint/), which also identifies a significant moment mid-way through the page load.
54 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
Changes proposed in this pull request: