-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aria-roledescription is flagged as invalid #9113
Comments
Thanks for the ticket! We may be running an older version of axe that doesn't pick this up. Possibly related to #7496 |
@CamiloGarciaLaRotta i updated the version of axe and indeed the result did change... "[aria-*] attributes are not valid or misspelled" is now passing.. BUT the exact same elements are failing a different rule: "[aria-*] attributes do not match their roles". This rule was passing previously. |
@WilcoFiers, @dylanb are y'all able to see anything that looks fishy in that output? |
These elements have a role of either |
@WilcoFiers @straker I have a feeling like the recent dequelabs/axe-core#1382 may resolve this ? |
Based on a quick read of the spec
And it's listed in the inherited properties tables for listitem and list. |
I'll take a look at this for axe. As far as I'm aware in axev3.2.2, |
Moved this over to the Lighthouse repo. Lighthouse was crashing for my in Canary so I wasn't able to test again :\ |
@straker did you already file any issue for this we can reference or do we need to file one? |
Hello, Is it possible that this is related to the fact that a It used to be not allowed in ARIA 1.0, but is allowed in ARIA 1.1. I have checked the source code of the AXE you are using and it seems it is not added: https://github.com/dequelabs/axe-core/blob/a4b524084cb8fd61e5ac802b3b6bc7a0d5f86668/lib/commons/aria/index.js#L436 The same is observed with role="listbox" also. |
Issue has been resolved. |
In which Lighthouse version is this issue supposed to be resolved? When running Lighthouse 5.7.0 with Chrome 81, I still get |
@Abdull fixed in 6.0.0-beta.0 not yet released to Chrome. |
Ah just found: https://web.dev/lighthouse-whats-new-6.0/, so pretty soon this fix will be in Chrome Stable? |
For the following website: https://camilogarcialarotta.github.io/
The message is:
aria-roledescription
is a valid tag as per: https://www.w3.org/TR/wai-aria-1.1/#aria-roledescriptionThe text was updated successfully, but these errors were encountered: