Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INP attribution helper latestProcessingEnd never initialized #510

Closed
rviscomi opened this issue Aug 6, 2024 · 1 comment · Fixed by #512
Closed

INP attribution helper latestProcessingEnd never initialized #510

rviscomi opened this issue Aug 6, 2024 · 1 comment · Fixed by #512

Comments

@rviscomi
Copy link
Member

rviscomi commented Aug 6, 2024

latestProcessingEnd is declared without a value, so it's initially undefined.

When comparing the undefined value with entry.processingEnd, the result is always NaN.

And finally, when the NaN value is compared with loaf.startTime the result is always false, so the LoAF entries are always kept.

@brendankenny
Copy link
Member

so the LoAF entries are always kept

one bit of good news is that this at least maxes out at MAX_PREVIOUS_FRAMES, so we don't keep more than 50 + 10 (if the 10 longest LoAFs aren't in the most recent 50), but yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants