-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: stable/tested Docker image provided by puppeteer team #2676
Comments
It's not exactly what you're asking for. But I built a cloud builder (really just a docker container that has puppeteer and yarn as an entrypoint) which is capable of running puppeteer on CI for apps that use yarn (node). https://github.com/GoogleCloudPlatform/cloud-builders-community/tree/master/yarn-puppeteer Aside from the yarn part you could base a docker image largely off that and open source it. Mine was largely based off the puppeteer documentation. |
@stopsopa To my knowledge, there are some successful projects that run puppeteer in docker (e.g. @joelgriffith's browserless). We still hope that Puppeteer community will converge on a single well-maintained docker container that will address most needs. We'll be glad to refer to it in our docs. |
@stopsopa what more would you like to see here? We have an official Dockerfile example in https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker. I'm not sure we need to maintain a container b/c it's easy enough to take that file and build the image yourself. |
@ebidel I agree, and eventually I've used this example... |
It would be nice if Puppeteer team would provide and maintain official Docker container with Puppeteer because lots of issues here are about problems with Docker container, and people (including me) have lots of different approaches to this subject but eventually they experiencing and describing similar problems with having stable and working image with Puppeteer and its generate lots of noise here in puppeteer Issue tracker.
Example - all below issues actually describe one issue (IMO) but it's hard to detect because it works fine on Mac (according to my extensive tests) but it appears on Linux which is usually production/target OS:
The text was updated successfully, but these errors were encountered: