core(lantern): link layout nodes to root frame request #9727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,8 +10,11 @@ const assert = require('assert'); | |||
|
|
|||
| const trace = require('../../fixtures/traces/progressive-app-m60.json'); | |||
| const devtoolsLog = require('../../fixtures/traces/progressive-app-m60.devtools.log.json'); | |||
| const iframeTrace = require('../../fixtures/traces/iframe.trace.json'); | |||
There was a problem hiding this comment.
can you add the chrome version this was captured in to the filename? i rather like that
54 tasks
paulirish
approved these changes
Oct 11, 2019
| function addDependencyOnFrame(cpuNode, frameId) { | ||
| if (!frameId) return; | ||
| const networkNode = networkNodeOutput.frameIdToNodeMap.get(frameId); | ||
| if (!networkNode || |
There was a problem hiding this comment.
break into two statements?
if (!networkNode) return;
if (... ) return;
brendankenny
approved these changes
Oct 25, 2019
| urlToNodeMap.set(record.url, urlList); | ||
|
|
||
| // If the request was for the root document of an iframe, save an entry in our | ||
| // map so we can't link up the task `args.data.frame` dependencies later in graph creation. |
There was a problem hiding this comment.
lol this is not the first major typo I have made today either...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE AND SHOULD NOT BE MERGED UNTIL 6.0
Summary
Fixes a bug in simulation where a large iframe's tasks are not linked to the main document request. In practice on our basket of sites this never makes a difference because script dominates anyhow, but it can make a substantial difference on reporting the perf of iframe-only pages (see #9719).
Related Issues/PRs
(probably) closes #9719