Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBW: suggest the use of client hints #876

Closed
ebidel opened this issue Oct 31, 2016 · 4 comments
Closed

DBW: suggest the use of client hints #876

ebidel opened this issue Oct 31, 2016 · 4 comments

Comments

@ebidel
Copy link
Contributor

ebidel commented Oct 31, 2016

e.g. if the device 400px wide, "why are you sending a 1200px wide image?"

https://www.chromestatus.com/features/5504430086553600

How? Grab all images loading by off the network, check their instrinsic size. Determine if they are too big given the DPR and size of the viewport tested.

e.g. Given a 2 DPR device and a 600px viewport, the appropriate image should be 600px * 2 = 1200px. Anything else is wasteful.

@olingern
Copy link
Contributor

olingern commented Nov 7, 2016

Hey @ebidel, I'd like to jump in on this one!

@ebidel
Copy link
Contributor Author

ebidel commented Nov 7, 2016

Sweet! This one might be more involved than a "good first bug" :\ It'll involve a couple of gatherers and some promise magic. There are a couple that might be even easier to start with:
#871
#718

Let us know what you'd like to tackle.

@olingern
Copy link
Contributor

olingern commented Nov 8, 2016

@ebidel I like a challenge 😄, but #871 sounds like a good stepping stone to this one. I'll pick up over there and see if I can send over a PR sometime soon

@patrickhulce
Copy link
Collaborator

addressed by #1497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants