Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome no longer returns eval'd scripts in captureJSCallUsage. #1286

Closed
ebidel opened this issue Dec 23, 2016 · 1 comment
Closed

Chrome no longer returns eval'd scripts in captureJSCallUsage. #1286

ebidel opened this issue Dec 23, 2016 · 1 comment

Comments

@ebidel
Copy link
Contributor

ebidel commented Dec 23, 2016 •
edited
Loading

captureJSCallUsage() is no longer returning violations that are eval'd.

Running the DBW tester, there should be 4 Date.now() violations, but only 2 show up:

screen shot 2016-12-23 at 3 28 19 pm

This may be a Chrome change that we need to investigate.

^ This is not an ad for United :)
@ebidel ebidel mentioned this issue Dec 24, 2016
Merged
@ebidel
Copy link
Contributor Author

ebidel commented Jan 12, 2017 •
edited
Loading

This seems to longer be an issue. We also have the new and improved smokehouse that will help us catch weirdness like this when it comes up.

@ebidel ebidel closed this as completed Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebidel