Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Error: Failed to construct 'URL': Invalid URL #1194

Closed
nirgn975 opened this issue Dec 21, 2016 · 16 comments
Closed

Extension Error: Failed to construct 'URL': Invalid URL #1194

nirgn975 opened this issue Dec 21, 2016 · 16 comments

Comments

@nirgn975
Copy link

Lighthouse Version: 1.3.0
Chrome Version: 55.0.2883.95
Error Message: Failed to construct 'URL': Invalid URL
Stack Trace:

   at artifacts.DateNowUse.usage.filter.err (chrome-extension://blipmdconlkpinefehnmjammfjpmpbjk/scripts/lighthouse-background.js:1046:39)
   at Array.filter (native)
   at Function.audit (chrome-extension://blipmdconlkpinefehnmjammfjpmpbjk/scripts/lighthouse-background.js:1045:48)
   at Promise.resolve.then._ (chrome-extension://blipmdconlkpinefehnmjammfjpmpbjk/scripts/lighthouse-background.js:11365:20)```
@ebidel
Copy link
Contributor

ebidel commented Dec 21, 2016

I thought this was a dupe of #1191, @brendankenny was going to look into this to make sure.

For kicks, can you shoot us the URL you're testing against?

@nirgn975
Copy link
Author

@ebidel It was https://lifelongstudent.io

@wardpeet
Copy link
Collaborator

@nirgn975 do you have this every time?
Extension got through just fine (downloaded from chrome store)

@brendankenny
Copy link
Member

I also can't reproduce this in the 1.3.0 extension for this URL or http://projectnovus.autodesk.com/staging.html as mentioned in #1197

I am running Chrome 57, though, and I notice all the bugs so far are using m55. Anyone have Chrome 55 to try? The URL spec is still in progress, so it's possible this was a corner case the URL constructor in Chrome was patched to handle.

I'll download a build of m55 tomorrow if no one else has gotten to it.

@nirgn975
Copy link
Author

@wardpeet Yes, I run it 3 times by now. The extension was already installed, I saw it was update itself and try to run it on my website (yesterday I run the old version and it was fine). I didn't close the browser from yesterday, and didn't press on anything to update the extension.

I'm on MacOS. I can try to close the browser and open it again or to uninstall and install it again from Chrome Web Store.

@brendankenny
Copy link
Member

I can try to close the browser and open it again or to uninstall and install it again from Chrome Web Store.

I doubt those things would improve matters. It's almost certainly our bug.

Would it be possible to copy some of the console log from Lighthouse into this issue? It would be very helpful if the URL it was trying to parse was in there.

It's a little awkward to get to because this is an extension, but you can access by navigating to chrome://extensions/, clicking the "Inspect views: background page" link under Lighthouse to open up DevTools, going to the console panel in devtools, then running the Lighthouse extension as you were. The log should output to the console as LH runs.

Hopefully in there at the end is the exception and the URL it was trying to parse (something similar to the message Eric got in the CLI form of this bug in this screenshot: #1186 (comment))

@nirgn975
Copy link
Author

@brendankenny I save the log as txt, hope it's okey.
blipmdconlkpinefehnmjammfjpmpbjk-1482307581059.txt

@ebidel
Copy link
Contributor

ebidel commented Dec 21, 2016

I wasn't able to repro on http://projectnovus.autodesk.com/staging.html using Chrome mac 55.0.2883.95.

However, the URLs that in the date.now audit triggers look like suspects from https://github.com/nodejs/node/issues/10306...if you take "between 4-9 digits" as meaning that it can be anywhere in the URL.

screen shot 2016-12-21 at 12 24 01 am

@Janpot
Copy link
Contributor

Janpot commented Dec 21, 2016

@ebidel no, it's only when the first segment of the hostname is a number

@wardpeet
Copy link
Collaborator

@nirgn975 Is it possible to give me your timezone :) and time of testing (local time). Also did you have turned off any audits?

@wardpeet wardpeet self-assigned this Dec 21, 2016
@wardpeet
Copy link
Collaborator

i'm on to something :)

@nirgn975
Copy link
Author

@wardpeet Of course, my time zone is UTC+2, and I was testing it at around 7:40 (AM).
No, I didn't turned off anything.

@wardpeet
Copy link
Collaborator

Will be fixed in next release 1.3.1

@pastelsky
Copy link

pastelsky commented Dec 25, 2016

I'm, on v1.3.2 and still getting this error!

@nirgn975
Copy link
Author

nirgn975 commented Dec 25, 2016

@wardpeet I have updated to 1.3.2 and I think I'm still getting the same error (log.txt)

@ebidel
Copy link
Contributor

ebidel commented Dec 25, 2016

@nirgn975 proper++ fix is in #1288. Going to have to wait until after the holidays to make a new release. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants