Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP Burndown #9

Closed
patrickhulce opened this issue Jul 11, 2019 · 1 comment
Closed

MVP Burndown #9

patrickhulce opened this issue Jul 11, 2019 · 1 comment
Labels

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jul 11, 2019

Burndown list created for items outstanding as of 2019-10-01 or later.

🎯 ✅ Gotta happen

UI

  • PWA Gauge (c881617)
  • numeric audit tweaks for overflow text (6eaf47d)
  • ellipsis overflow text on audit name (6eaf47d)
  • use SVG for the border triangle icon (48a30ef)
  • multiple URL graphs on project dashboard (e24d46f)
  • support node details type in table (f655599)
  • markdown description support (2e9a282)
  • pass/fail/icon indicator in audit detail view (2e9a282)
  • hide gauges when detail is expanded (ccf61b6)
  • simplified deltas when detail is expanded (ccf61b6)
  • numeric diff in detail view (b142e82)
  • move numeric diff delta label to right side when it goes to 0 (2d4f0db)
  • only metrics get numeric diff in list view (98b0ca2)
  • use closest previous build time when exact ancestor is not known (2ceebda)
  • double render preact bug fix (81569a6)
  • close remaining details table gaps
    • main-thread work items (68dfdac)
    • enormous network payload items (68dfdac)
    • fall back to display value when no diff available (0e0df55)
    • link details type (844110a)
  • bug fix for different URLs in UI (f7e797e)
  • diff logic improvements
  • limit builds in hash selector (4f5476a)
  • limit statistics fetched for dashboard (4f5476a)
  • fix same branch compare/base (91a4c7a)
  • label only "added"/"removed" and move to before first numeric cell (5bf7b48)
  • add percentages everywhere (2f0fb8e)
  • smaller font size of upper/lower limits (ead96e7)
  • use ms everywhere for deltas (7c1e5ff)
  • branch picker on project dashboard (ec95bc8)
  • move avatar inside pill (5e3e71e)
  • extend hover color to entire build picker row (4bcaa4e)
  • revert back to pill background instead of header (4bcaa4e)
  • tweak base/compare pill colors in hash picker (4bcaa4e)
  • run through all spec colors/sizes in figma
  • consolidation of error states on "no diff" view (be6a263)
  • legit loading spinner (f22bb8c)
  • faded out base/compare chip hash selector (4bcaa4e)
  • optional merge base (make ancestorHash optional #36)
  • no diff available fixes for opportunities (c4a2c40) (eaffaf2) (f87124a)
  • handle image thumbnail failure to load (14666ac)
  • favicon (2dc0f90)
  • project pane on scroll isn't full viewport width (0f9ff47)
  • fix base+compare on same branch (1b4619f)
  • friendly URLs (696a95e)
  • synthesize group for best practices audits (4fcf7af)

CLI

  • update notifier (7bcd7f2)
  • rename to staticDistDir (6244102)
  • assert on median build, not just median value (70aef52)
  • upload URL replacements for <port>, <uuid>, etc (ccb528b)
  • generate lighthouserc from budgets.json (00cf1a4)
  • lighthouserc granular budget assertions (3d29976)
  • assert allow assertion on multiple urls/patterns as keys in matrix
  • update the lighthouse:recommended preset (e78b25a)
  • rename mergeMethod to aggregationMethod (c0329f1)
  • support file-wide default aggregationMethod (6c098cd)
  • collect mode with a server for local files (ebbe030)
  • automegadoeverything command (5e42e21)
  • print audit titles and learn more link (261fd0a)
  • healthcheck that fails/warns when things aren't configured correctly (add a healthcheck command #38)
  • list item details on failure

API

Tests

  • multiple URL comparison test in build view (914dbd7)
  • setup LHCI on itself for homepage, project dashboard, build view (13c9bfd)
  • setup assert flow in dogfood (0cc0178)

Perf

  • spin up a test server of 50 LHRs/build, 1000 builds (n1-standard-1 handled 3700 LHRs with 75 builds easily, only ~2GB sqlite file, ~20ms response times for common queries, 300ms response times for lifecycle/statistic computation)

Docs

  • document versioning strategy for breaking changes
  • document healthcheck and common mistakes (git depth, external contributions preventing githubToken, creating empty commits to rerun, etc)
  • document assertion format with basic examples (9e10393)
  • getting started guide (6babedc)
  • update docs for optionality of fallback server (5943427)
  • docs on automegadoeverything command (5943427)

Design Feedback

Misc

  • publish docker image with 0.3.0
  • update all examples with install of 0.3.x

🌆 ☑️ Nice to have

UI

  • warning when using a different build from exact ancestor (47f968f)
  • LH report link next to legend (1188120)
  • minimum diff threshold slider on build view (1188120)
  • clicking off build hash picker closes it (0652474)
  • redesign of "no diff" view (47f968f)
  • new pill design for item deltas
  • recent activity pagination
  • git tree visualization on build-view hash picker
  • nicer tooltips (Tooltip component #30)
  • --start-server-command (--start-server-command #37) (feat(cli): add startServerCommand option #46)
  • audit-specific icons (c7934e6)
  • add color to the gauges when there is no diff at all
  • calibrated/overview metrics
  • dates on hash picker commits
  • nicer design of empty states (4d268a7) (04126b8) (3913e43)
  • closeable warning boxes
  • diff logic improvements
    • extract numbers from displayValue and use those for ignorable thresholds
    • ignore pass -> pass variance (68a906d)

API

  • pagination on builds
  • GH app and proxy service
    • create the actual GH app/logo/copy/etc
    • route to create a GH token for you
    • route to validate the GH token against the repo and post the status to GH

CLI

  • upload target of transient cloud storage service (cbad14d)
  • upload sets a GH status check bit (97d2639)
  • automatically find a local .lighthouserc (bd7d44c)
  • assert against category scores (13c687e)
  • open command view HTML reports (df13eb4)

Docs

  • document travis CI setup for basic assert flow
  • document installation of CI server
  • document different ways to use budgets.json with lighthouse ci

🏈 🏖 Punt till after CDS


CDS Feedback

@patrickhulce
Copy link
Collaborator Author

Separate issues have been filed for efforts that deserve separate tracking, closing as the MVP has shipped! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant