Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When device network is cut, app shows incorrect ONLINE Status #94

Closed
kkalarickal opened this issue Mar 12, 2021 · 1 comment · Fixed by #104
Closed

When device network is cut, app shows incorrect ONLINE Status #94

kkalarickal opened this issue Mar 12, 2021 · 1 comment · Fixed by #104
Assignees
Labels
bug Something isn't working

Comments

@kkalarickal
Copy link

kkalarickal commented Mar 12, 2021

Bug Description

There is a ONLINE/OFFLINE status message at the bottom of the page view for the app. When physical internet connection is broken (by switching off WiFi or going into Airplane mode without data connection), this status message remains ONLINE even though there is no internet connection. As a result perhaps, the videos that are not available for offline viewing show up as active (not shaded). This is confusing to the user.

Expected Behaviour

The status should get updated to OFFLINE when network connection is broken and all the videos that are NOT downloaded for offline viewing should be greyed out.

Steps to reproduce

  1. Go to KINO Staging Site on Google Chrome
  2. Click on the button to download some videos for offline viewing. NOTE that the status shows ONLINE.
  3. Now break the network connection to the device by switching off WiFi or go into Airplane mode without data connection.
  4. Notice that the status still shows ONLINE.
  5. Also NOTE that the video cards that are NOT available for offline viewing still show as active along with the downloaded videos.

Screenshots

Screenshot showing how video cards and status behaves when network connection is cut
image

Additional context

  • Project version: da8ec7d
  • Node version: n.a.
  • OS: Win10
  • Browser: chrome
  • Device: Galaxy S III

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@kkalarickal
Copy link
Author

This is verified on 6a3f38f

Also, per #105 (comment) It looks like there is a difference between making the service worker offline vs. cutting the network connection. For the former, the behavior is as expected. For the latter, the behavior is not supported as of now.

@kkalarickal kkalarickal reopened this Mar 23, 2021
@kkalarickal kkalarickal self-assigned this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant