Add Extensions API blog post for documentId and friends. #3903

dtapuska · 2022-10-04T15:48:27Z

Instant Navigation adds additional fields documentId, parentDocumentId, documentLifecycle, frameType to help improve the experience for back/forward cache and prerendering.

https://deploy-preview-3903--developer-chrome-com.netlify.app/blog/extension-instantnav/

netlify · 2022-10-04T15:48:32Z

✅ Deploy Preview for developer-chrome-com ready!

Name	Link
🔨 Latest commit	`f4ca076`
🔍 Latest deploy log	https://app.netlify.com/sites/developer-chrome-com/deploys/6387ce556a66f10009182c3c
😎 Deploy Preview	https://deploy-preview-3903--developer-chrome-com.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dotproto · 2022-10-13T00:49:58Z

@jpmedley, FYI I'm tagging you in on this PR a little early. I figure It might be worth seeing how it reads & flows.

jpmedley · 2022-10-13T14:42:26Z

@dotproto,

Thank you! Much appreciated.

jpmedley · 2022-10-13T14:44:21Z

@dtapuska,

The review Simeon asked me to do is very meta. When the text is locked I'll do a copy edit (review for typos, spelling, punctuation, etc.)

site/en/blog/extension-instantnav/index.md

jpmedley · 2022-10-14T14:48:03Z

@dtapuska, @dotproto

the structure of this looks pretty good. I made a few comments, but won't do a thorough edit until you you tell me the text is locked.

dtapuska · 2022-10-20T17:22:48Z

@dotproto ping, PTAL

jpmedley · 2022-11-04T14:40:14Z

@dotproto Is there anything I can do to help you move this?

dotproto

Added some suggestions to clean up the information presentation a bit. Once these are settled I think we're good for @jpmedley to take a final pass.

site/en/blog/extension-instantnav/index.md

jpmedley · 2022-11-08T21:41:03Z

@dotproto If you have no more comments, please approve this. I'll do my review then.

dotproto

LGTM

jpmedley

Dave,

Nice article! Don't let the number of changes scare you. Most of these are to make the article consistent with the rest of the site.

Unfortunately, there are a few items, we need to give some thought to.

site/en/blog/extension-instantnav/index.md

dtapuska

Applied fixes

site/en/blog/extension-instantnav/index.md

dtapuska · 2022-11-29T18:11:23Z

site/en/blog/extension-instantnav/index.md

+tab only had one active page. This was always the one that was visible. If a
+user returns to the previous page, the active page would be destroyed (Page B)
+and the previous page in history would be completely reconstructed (Page A).
+Extensions did not need to worry about what life cycle pages were in because


site/en/blog/extension-instantnav/index.md

dtapuska · 2022-11-29T18:44:46Z

site/en/blog/extension-instantnav/index.md

+
+When a page transitions from either Back/Forward Cache or prerender to the
+active state there will be 3 more events (but with *documentLifecyle*
+being *active*).


dtapuska · 2022-11-29T18:45:02Z

site/en/blog/extension-instantnav/index.md

+```js
+onBeforeNavigate -> onCommitted -> onCompleted
+```


site/en/blog/extension-instantnav/index.md

jpmedley · 2022-11-29T21:15:04Z

site/en/blog/extension-instantnav/index.md

+- `"fenced_frame"`: A special type of frame that is embedded inside other frames
+(see [fenced-frames](https://github.com/WICG/fenced-frame))


The odds are about 1.5 million to 1 that this value can even be used on a particular site. (My numbers are based on metrics for Chrome and origin trials.) I was trying to convince you to remove this completely. How about just saying 'Reserved for future use'?

jpmedley · 2022-11-29T21:44:06Z

@rachelandrew I think we're past the original publish date in our content request. When can this go up.

rachelandrew · 2022-11-29T22:31:16Z

@jpmedley does it work to publish this tomorrow (30th)? That way it goes out between new in Chrome (today) and the beta post (the 1st)

- Instant Navigation adds additional fields documentId, parentDocumentId, documentLifecycle, frameType to help improve the experience for back/forward cache and prerendering.

jpmedley · 2022-11-29T22:44:29Z

We can do tomorrow. Let me change the date real quick. and get Dave to merge it.

jpmedley · 2022-11-29T22:45:24Z

It looks like Dave already did that. I'll leave this open in a tab and merge first thing tomorrow.

ilyaspiridonov mentioned this pull request Oct 4, 2022

translations preview Qiskit/platypus#1609

Closed

dotproto requested review from dotproto and jpmedley October 13, 2022 00:31

jpmedley reviewed Oct 14, 2022

View reviewed changes

site/en/blog/extension-instantnav/index.md Outdated Show resolved Hide resolved

jpmedley reviewed Oct 14, 2022

View reviewed changes

site/en/blog/extension-instantnav/index.md Outdated Show resolved Hide resolved

jpmedley reviewed Oct 14, 2022

View reviewed changes

site/en/blog/extension-instantnav/index.md Outdated Show resolved Hide resolved

dtapuska force-pushed the main branch from 6ab5612 to fb1919f Compare October 19, 2022 21:57

dotproto added extensions Issues related to extensions documentation. content labels Nov 7, 2022

dotproto suggested changes Nov 8, 2022

View reviewed changes

dtapuska force-pushed the main branch from fb1919f to 48ba151 Compare November 8, 2022 16:13

dotproto approved these changes Nov 15, 2022

View reviewed changes

dotproto assigned jpmedley Nov 15, 2022

jpmedley suggested changes Nov 17, 2022

View reviewed changes

jpmedley assigned dtapuska Nov 28, 2022

dtapuska commented Nov 29, 2022

View reviewed changes

dtapuska force-pushed the main branch from 48ba151 to f27c635 Compare November 29, 2022 18:54

jpmedley suggested changes Nov 29, 2022

View reviewed changes

dtapuska force-pushed the main branch 3 times, most recently from 4b99c32 to 57a95fe Compare November 29, 2022 21:32

jpmedley approved these changes Nov 29, 2022

View reviewed changes

jpmedley added the DO NOT MERGE label Nov 29, 2022

Add Extensions API blog post for documentId and friends.

88d2f15

- Instant Navigation adds additional fields documentId, parentDocumentId, documentLifecycle, frameType to help improve the experience for back/forward cache and prerendering.

dtapuska force-pushed the main branch from 8e12e0e to 88d2f15 Compare November 29, 2022 22:43

Merge branch 'main' into main

f5e7db9

jpmedley removed the DO NOT MERGE label Nov 30, 2022

Merge branch 'main' into main

f4ca076

jpmedley merged commit ad377c1 into GoogleChrome:main Nov 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Extensions API blog post for documentId and friends. #3903

Add Extensions API blog post for documentId and friends. #3903

dtapuska commented Oct 4, 2022 •

edited by dotproto

Loading

netlify bot commented Oct 4, 2022 •

edited

Loading

dotproto commented Oct 13, 2022

jpmedley commented Oct 13, 2022

jpmedley commented Oct 13, 2022

jpmedley commented Oct 14, 2022

dtapuska commented Oct 20, 2022

jpmedley commented Nov 4, 2022

dotproto left a comment

jpmedley commented Nov 8, 2022

dotproto left a comment

jpmedley left a comment

dtapuska left a comment

dtapuska Nov 29, 2022

dtapuska Nov 29, 2022

dtapuska Nov 29, 2022

jpmedley Nov 29, 2022

jpmedley commented Nov 29, 2022

rachelandrew commented Nov 29, 2022

jpmedley commented Nov 29, 2022

jpmedley commented Nov 29, 2022

		- `"fenced_frame"`: A special type of frame that is embedded inside other frames
		(see [fenced-frames](https://github.com/WICG/fenced-frame))

Add Extensions API blog post for documentId and friends. #3903

Add Extensions API blog post for documentId and friends. #3903

Conversation

dtapuska commented Oct 4, 2022 • edited by dotproto Loading

netlify bot commented Oct 4, 2022 • edited Loading

✅ Deploy Preview for developer-chrome-com ready!

dotproto commented Oct 13, 2022

jpmedley commented Oct 13, 2022

jpmedley commented Oct 13, 2022

jpmedley commented Oct 14, 2022

dtapuska commented Oct 20, 2022

jpmedley commented Nov 4, 2022

dotproto left a comment

Choose a reason for hiding this comment

jpmedley commented Nov 8, 2022

dotproto left a comment

Choose a reason for hiding this comment

jpmedley left a comment

Choose a reason for hiding this comment

dtapuska left a comment

Choose a reason for hiding this comment

dtapuska Nov 29, 2022

Choose a reason for hiding this comment

dtapuska Nov 29, 2022

Choose a reason for hiding this comment

dtapuska Nov 29, 2022

Choose a reason for hiding this comment

jpmedley Nov 29, 2022

Choose a reason for hiding this comment

jpmedley commented Nov 29, 2022

rachelandrew commented Nov 29, 2022

jpmedley commented Nov 29, 2022

jpmedley commented Nov 29, 2022

dtapuska commented Oct 4, 2022 •

edited by dotproto

Loading

netlify bot commented Oct 4, 2022 •

edited

Loading