Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Improve documents: [content scripts] dynamic declarations with dynamic host permissions #5645

Closed
hanguokai opened this issue Mar 13, 2023 · 1 comment
Assignees
Labels
bug Something on the site is broken! extensions Issues related to extensions documentation. P2 A normal priority task. This is the default for most issues.

Comments

@hanguokai
Copy link
Contributor

Related documents that need to be improved:

See this discussion: scripting.registerContentScripts() when there are no host permissions

There are documents about "Inject content scripts with dynamic declarations". But the doc doesn't say the relationship between registerContentScripts() and host permissions. In fact, if there is no host permissions, registerContentScripts() still execute successfully, but no content scripts will be injected to pages. Therefore, to use dynamic declarations correctly, it needs to cooperate with chrome.permissions.contains() and chrome.permissions.request().

@hanguokai hanguokai added bug Something on the site is broken! P2 A normal priority task. This is the default for most issues. labels Mar 13, 2023
@AaronForinton AaronForinton added the extensions Issues related to extensions documentation. label Mar 13, 2023
@AmySteam AmySteam assigned AmySteam and unassigned jpmedley Mar 24, 2023
@dstmarthe
Copy link
Collaborator

Thanks for raising this. We’re moving to a new platform and so we’ll fix this over there. I’ve moved the issue to our new tracker and you can see it at https://issuetracker.google.com/issues/311090117

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something on the site is broken! extensions Issues related to extensions documentation. P2 A normal priority task. This is the default for most issues.
Projects
None yet
Development

No branches or pull requests

6 participants
@hanguokai @jpmedley @AmySteam @dstmarthe @AaronForinton and others