Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SwiftUI support #1

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

marekVrican
Copy link
Contributor

No description provided.

@marekVrican marekVrican force-pushed the feature/GoodReactorSwiftUI branch from 687b63b to d42f6cc Compare March 13, 2023 14:57
@marekVrican marekVrican force-pushed the feature/GoodReactorSwiftUI branch from d42f6cc to ae95dba Compare March 13, 2023 15:12
@vaIerika
Copy link

@plajdo @andrej-jasso Lets already merge that PR? 😄
@marekVGR Approved, good job! 👍🏼 Please add documentation I mentioned.

@vaIerika vaIerika self-requested a review March 17, 2023 09:46
Copy link
Contributor

@plajdo plajdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaIerika I'm okay with these changes, it should even work as a drag&drop replacement IIRC.

Just an idea I wanted to propose:

I think viewModel.currentState. is a lot of repetitive "boilerplate" to write on every single state access, especially on data-heavy views. Maybe we could do something about that in the future?

@andrej-jasso
Copy link
Contributor

andrej-jasso commented Mar 17, 2023

@vaIerika I'm okay with these changes, it should even work as a drag&drop replacement IIRC.

Just an idea I wanted to propose:

I think viewModel.currentState. is a lot of repetitive "boilerplate" to write on every single state access, especially on data-heavy views. Maybe we could do something about that in the future?

@plajdo Excelent idea to put into the innovation board ;) don't forget to add it there even if you have similar ideas in the future.

@marekVrican marekVrican merged commit 6ffbffb into main Mar 17, 2023
@marekVrican marekVrican deleted the feature/GoodReactorSwiftUI branch March 17, 2023 12:52
plajdo added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants