Merge pull request #11 from GoodRequest/feature/update-logger

Update logger dependency
GoodRequest · Jan 30, 2025 · 9e8a6a5 · 9e8a6a5
2 parents 9f36168 + 849d0a0
commit 9e8a6a5
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 13 deletions.
diff --git a/GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj b/GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj
@@ -14,6 +14,7 @@
 		099D61732C8472D300B86922 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 099D61722C8472D300B86922 /* GoodNetworking */; };
 		099D617F2C84A3CC00B86922 /* RandomNumber.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617C2C84A3CC00B86922 /* RandomNumber.swift */; };
 		099D61802C84A3CC00B86922 /* RNGEndpoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617D2C84A3CC00B86922 /* RNGEndpoint.swift */; };
+		3F8C10772D4B7E16000A4CC0 /* GoodCoordinator in Frameworks */ = {isa = PBXBuildFile; productRef = 3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */; };
 		6B9596242D3E690B0037D874 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 6B9596232D3E690B0037D874 /* GoodNetworking */; };
 		EA51F944299424A900B14A7C /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = EA51F943299424A900B14A7C /* AppDelegate.swift */; };
 		EA51F94F299424AA00B14A7C /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA51F94E299424AA00B14A7C /* Assets.xcassets */; };
@@ -71,6 +72,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				3F8C10772D4B7E16000A4CC0 /* GoodCoordinator in Frameworks */,
 				09545AF22CB6705100DC5A61 /* GoodReactor in Frameworks */,
 				0908A6462C91C0B10035A749 /* GoodCoordinator in Frameworks */,
 			);
@@ -279,6 +281,7 @@
 			packageProductDependencies = (
 				0908A6452C91C0B10035A749 /* GoodCoordinator */,
 				09545AF12CB6705100DC5A61 /* GoodReactor */,
+				3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */,
 			);
 			productName = "goodreactor-swiftui-sample";
 			productReference = 092188B02C8CD2A100C6085A /* goodreactor-swiftui-sample.app */;
@@ -335,8 +338,8 @@
 			);
 			mainGroup = EA51F937299424A900B14A7C;
 			packageReferences = (
-				0908A6442C91C0B10035A749 /* XCLocalSwiftPackageReference "../../GoodCoordinator-iOS" */,
 				6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */,
+				3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */,
 			);
 			productRefGroup = EA51F941299424A900B14A7C /* Products */;
 			projectDirPath = "";
@@ -687,14 +690,15 @@
 		};
 /* End XCConfigurationList section */
 
-/* Begin XCLocalSwiftPackageReference section */
-		0908A6442C91C0B10035A749 /* XCLocalSwiftPackageReference "../../GoodCoordinator-iOS" */ = {
-			isa = XCLocalSwiftPackageReference;
-			relativePath = "../../GoodCoordinator-iOS";
-		};
-/* End XCLocalSwiftPackageReference section */
-
 /* Begin XCRemoteSwiftPackageReference section */
+		3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */ = {
+			isa = XCRemoteSwiftPackageReference;
+			repositoryURL = "https://github.com/GoodRequest/GoodCoordinator-iOS";
+			requirement = {
+				kind = upToNextMajorVersion;
+				minimumVersion = 3.0.3;
+			};
+		};
 		6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */ = {
 			isa = XCRemoteSwiftPackageReference;
 			repositoryURL = "https://github.com/GoodRequest/GoodNetworking";
@@ -726,6 +730,11 @@
 			isa = XCSwiftPackageProductDependency;
 			productName = GoodNetworking;
 		};
+		3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */ = {
+			isa = XCSwiftPackageProductDependency;
+			package = 3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */;
+			productName = GoodCoordinator;
+		};
 		6B9596232D3E690B0037D874 /* GoodNetworking */ = {
 			isa = XCSwiftPackageProductDependency;
 			package = 6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */;

diff --git a/...le/GoodReactor-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/...le/GoodReactor-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -1,5 +1,5 @@
 {
-  "originHash" : "05343bd7e7b239e89ddc6777d3bb2528b16e94b9f65472a9799b055078ae4795",
+  "originHash" : "c18ed7d4c3eb52cbc342b966d828442d2dfac554400b8af9825017e69d038392",
   "pins" : [
     {
       "identity" : "alamofire",
@@ -37,13 +37,22 @@
         "version" : "1.8.1"
       }
     },
+    {
+      "identity" : "goodcoordinator-ios",
+      "kind" : "remoteSourceControl",
+      "location" : "https://github.com/GoodRequest/GoodCoordinator-iOS",
+      "state" : {
+        "revision" : "3b5fc8c164477a2ff3ad902cf7e5854015dcc147",
+        "version" : "3.0.3"
+      }
+    },
     {
       "identity" : "goodlogger",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/GoodRequest/GoodLogger.git",
       "state" : {
-        "revision" : "8203802fcff9163a309bd5edd44cc6f649404050",
-        "version" : "1.2.4"
+        "revision" : "14318cd3a38a08ac49e2b1dee56386904fedecc5",
+        "version" : "1.3.0"
       }
     },
     {
@@ -99,6 +108,15 @@
         "revision" : "9bf03ff58ce34478e66aaee630e491823326fd06",
         "version" : "1.1.3"
       }
+    },
+    {
+      "identity" : "swift-syntax",
+      "kind" : "remoteSourceControl",
+      "location" : "https://github.com/apple/swift-syntax.git",
+      "state" : {
+        "revision" : "0687f71944021d616d34d922343dcef086855920",
+        "version" : "600.0.1"
+      }
     }
   ],
   "version" : 3

diff --git a/GoodReactor-Sample/goodreactor-swiftui-sample/Screens/LoginView/LoginViewModel.swift b/GoodReactor-Sample/goodreactor-swiftui-sample/Screens/LoginView/LoginViewModel.swift
@@ -49,6 +49,9 @@ import Observation
                 // no mutation
                 return nil
             }
+
+        case .destination(_):
+            break
         }
     }
 

diff --git a/Package.swift b/Package.swift
@@ -23,7 +23,7 @@ let package = Package(
         .package(url: "https://github.com/CombineCommunity/CombineExt.git", from: "1.8.1"),
         .package(url: "https://github.com/apple/swift-async-algorithms.git", .upToNextMajor(from: "1.0.0")),
         .package(url: "https://github.com/apple/swift-collections.git", .upToNextMajor(from: "1.1.3")),
-        .package(url: "https://github.com/GoodRequest/GoodLogger.git", .upToNextMajor(from: "1.1.0"))
+        .package(url: "https://github.com/GoodRequest/GoodLogger.git", .upToNextMajor(from: "1.3.0"))
     ],
     targets: [
         .target(

diff --git a/Sources/GoodReactor/Reactor.swift b/Sources/GoodReactor/Reactor.swift
@@ -535,7 +535,7 @@ private extension Reactor {
     }
 
     private static func _debugLog(message: String) {
-        logger.log(level: .debug, message: "[GoodReactor] \(Self.name) - \(message)", privacy: .auto)
+        logger.log(message: "[GoodReactor] \(Self.name) - \(message)", level: .debug)
     }
 
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,9 @@ import Observation @@
                     // no mutation
                     return nil
                 }
+            case .destination(_):
+                break
             }
         }
@@ Expand Down @@