You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 17, 2024. It is now read-only.
Actually, I don't think it should ever be library's responsibility to set up polyfills. You may require user to install and configure them by themselves.
This package have hard dependency on core-js/promise polyfill. When used with Angular, we cannot ensure Promise polyfill is loaded before zone.js (a dependency of Angular) is loaded. Note that we are using separate js files and the js file using dataframe-js is loaded after the Angular app is loaded. Due to angular/zone.js#783 and zloirock/core-js#319, when core-js/promise module is loading, it will replace window.Promise from ZoneAwarePromise (patched by zone.js) back to native Promise, and breaks Angular's change detection.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
Desktop (please complete the following information):
OS: Windows
Browser: Chrominum Edge
Version: Dev 77.0.235.5
Smartphone (please complete the following information):
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]
Additional context
The text was updated successfully, but these errors were encountered:
JS ecosystem can be an incredible mess sometimes.
I will see to create a temporary workaround (I can't drop core-js just like that, or I will take one thousand issues).
Stay tuned.
Describe the bug
Please remove the following line
dataframe-js/lib/io.js
Line 9 in 9d6226a
Actually, I don't think it should ever be library's responsibility to set up polyfills. You may require user to install and configure them by themselves.
This package have hard dependency on
core-js/promise
polyfill. When used with Angular, we cannot ensure Promise polyfill is loaded before zone.js (a dependency of Angular) is loaded. Note that we are using separate js files and the js file usingdataframe-js
is loaded after the Angular app is loaded. Due to angular/zone.js#783 and zloirock/core-js#319, whencore-js/promise
module is loading, it will replacewindow.Promise
fromZoneAwarePromise
(patched by zone.js) back to nativePromise
, and breaks Angular's change detection.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: