Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide count when filtering #925

Closed
garretthyder opened this issue Sep 20, 2018 · 5 comments
Closed

Provide count when filtering #925

garretthyder opened this issue Sep 20, 2018 · 5 comments
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@garretthyder
Copy link

A request was originally made on GlotDict to provide a count of the strings returned when filtering;
Mte90/GlotDict#179 (comment)

I looked into this for GlotDict but when the results are paginated the information isn't available to javascript without unnecessary requests.

It would be nice to have a notice appear when the filter is run with the results count similar to the notices you receive when importing or bulk submitting;
screen shot 2018-09-20 at 12 57 06 am
screen shot 2018-09-20 at 12 59 01 am

Thanks

@toolstack
Copy link
Contributor

How about we add a "Current Filter" count to the end of the standard count list when a filter is active. Something like:

current filter

@toolstack toolstack added the [Type] Enhancement A suggestion for improvement. label Sep 20, 2018
@toolstack toolstack added this to the 3.0 milestone Sep 20, 2018
@garretthyder
Copy link
Author

Thanks @toolstack

That could suffice, although we might want to make it not look like a link or users could be confused and try clicking at it.

I posted a quick thought in Slack - https://wordpress.slack.com/archives/C02RP4R9F/p1537459419000100

I was either thinking that could be a notice with the filter count. Or if the pagination is just updated to give numbers like 1-100 of 1000 that would probably also suffice and could be useful to all views not just filter views

Thanks

@toolstack
Copy link
Contributor

It will be a link, and you can click on it ;)

That way you can refresh the current filtered view.

The problem with ranges is that it makes the pagination control much larger, which isn't good on small displays.

@garretthyder
Copy link
Author

That's a good point @toolstack I hadn't thought of a need to refresh but as you can affect strings in view to have them removed from the filter a refresh is a useful thing.
And I agree the count in pagination could be overbearing there.
Let's go with your initial proposal there, thanks for providing a use case for why making it a link is helpful

@toolstack toolstack added the [Status] In Progress Tracking issues with work in progress label Sep 25, 2018
@khoipro
Copy link

khoipro commented Oct 12, 2018

+1 (like)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants