Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Sets: A failed update redirects to /sets/-new #349

Closed
ocean90 opened this issue Mar 17, 2016 · 5 comments
Closed

Translation Sets: A failed update redirects to /sets/-new #349

ocean90 opened this issue Mar 17, 2016 · 5 comments
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Mar 17, 2016

Steps to reproduce:

  1. Create a new translation set
  2. Go to the edit page of that set
  3. Clear the locale value
  4. (Clear the name field)
  5. Click Save

Expected: You stay on the edit page.
Actual: You're at /sets/-new.

@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Mar 17, 2016
@toolstack
Copy link
Contributor

PR #331 solves that by using the locale name for the name field if it is blank.

More interestingly though is another issue, when you edit the set the Locale isn't selected correctly as the option value has "checked" instead of "selected" used.

@ocean90
Copy link
Member Author

ocean90 commented Mar 17, 2016

@toolstack Not it doesn't, that's why I created this issue. :)

@toolstack
Copy link
Contributor

Works on my install correctly, let me double check.

The other issue is because the on line 243 of template.php checked() is used instead of selected().

@ocean90 ocean90 added this to the 1.1 milestone Mar 17, 2016
@ocean90 ocean90 self-assigned this Mar 17, 2016
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Mar 17, 2016
@ocean90
Copy link
Member Author

ocean90 commented Mar 17, 2016

@toolstack Updated the steps to reproduce.

@ocean90 ocean90 removed the [Status] In Progress Tracking issues with work in progress label Mar 17, 2016
@toolstack
Copy link
Contributor

Ah, got it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Development

No branches or pull requests

2 participants