Improve i18n

[ocean90]

Previously: #16

• Placeholders aren't explained in a translator comments
• The use of _n() is wrong in some cases, like _n('One translation rejected.', '%d translations rejected.', $ok, 'glotpress' ), $ok );
• Strings like __( 'edit', 'glotpress' ) should get a context: _x( 'edit', 'glossary', 'glotpress' )
• esc_attr( __( ) ) should be esc_attr__( )
• echo _x( ) should be _ex( )

Note: Each point can have its own PR.

[toolstack]

PR #101 cleans up _n().

[shield-9]

Some strings in gp-templates/project-permissions.php would be impossible to be translated into some languages. (For example, Japanese.)

[toolstack]

Could you provide an example of what can't be translated?

Items like the slug, username, login id, etc. aren't translated as they shouldn't be.

[shield-9]

@toolstack: Japanese has quite different sentence structure. In this case, word order is the problem. Here's an example:

• English: user <a href="{user_nicename}">{user_login}</a> can {action} strings with locale {locale_slug} and slug {set_slug}
• Japanese: ユーザー <a href="{user_nicename}">{user_login}</a> はロケール {locale_slug} で、スラッグ {set_slug} の文字列を {action} できます

[toolstack]

@shield-9 take a look at #188, would that work better?

[ramiy]

See also https://github.com/deliciousbrains/GlotPress/pull/198

Merge similar strings with different variations and avoid using HTML <code> tags in translation strings.

[pedro-mendonca]

Hi @ocean90

I have some suggestions to improve i18n.

• Merge the following Priority labels (have commit):

• Priority of the original:

• Priority:

• Move arrows outside of the following strings and merge similar (have commit):

• Project actions ↓

• Project actions ↑

• Personal project options ↓

• Personal project options ↑

[pedro-mendonca]

Hi @ocean90,
Regarding the above item:

• Strings like __( 'edit', 'glotpress' ) should get a context: _x( 'edit', 'glossary', 'glotpress' )

Did you mean the __( '(edit)', 'glotpress' ) used for Glossary, Project and Translation set?

There are also these two, that I believe you weren't refering to:
__( 'Edit', 'glotpress' ),
__( 'Delete', 'glotpress' ),

[pedro-mendonca]

I'll post here another I18n issue that occurs in many pages:

The action links aren't separated with a space.
This would be easily fixed as below:
Current code example:
return gp_link_get( gp_url( gp_url_join( '/glossaries', $glossary->id, '-edit' ) ), $text, gp_attrs_add_class( $attrs, 'action edit' ) );

Fix with prepend empty space on add custom text link:
return gp_link_get( gp_url( gp_url_join( '/glossaries', $glossary->id, '-edit' ) ), ' ' . $text, gp_attrs_add_class( $attrs, 'action edit' ) );