Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Notice: Undefined property: Translation_Entry::$user_login in /gp-templates/translation-row.php #386

Closed
ocean90 opened this issue Apr 6, 2016 · 0 comments
Closed

PHP Notice: Undefined property: Translation_Entry::$user_login in /gp-templates/translation-row.php #386

ocean90 opened this issue Apr 6, 2016 · 0 comments
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone
2.1

Comments

@ocean90
Copy link
Member

ocean90 commented Apr 6, 2016 

Notice: Undefined property: Translation_Entry::$user_login in /gp-templates/translation-row.php on line 12

Happens if a translation has a user_id but the user was deleted in the meantime. See https://github.com/GlotPress/GlotPress-WP/blob/2.0.0/gp-includes/things/translation.php#L254-L256
@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Apr 6, 2016
@ocean90 ocean90 added this to the 2.1 milestone Apr 6, 2016
ocean90 added a commit that referenced this issue Apr 6, 2016
@ocean90
Translations: Initialize user_login, user_display_name, and `user…
dd5e112 
…_nicename` properties.

Avoids an undefined property PHP notice if the user doesn't exist anymore.

Fixes #386.
@ocean90 ocean90 mentioned this issue Apr 6, 2016
Merged
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Apr 6, 2016
toolstack pushed a commit that referenced this issue Apr 25, 2016
@ocean90 @toolstack
Translations: Initialize user_login, user_display_name, and `user…
ce1f5f1 
…_nicename` properties.

Avoids an undefined property PHP notice if the user doesn't exist anymore.

Fixes #386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@ocean90