Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to translations to be imported with status waiting #377

Closed
akirk opened this issue Mar 31, 2016 · 3 comments
Closed

Allow to translations to be imported with status waiting #377

akirk opened this issue Mar 31, 2016 · 3 comments
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@akirk
Copy link
Member

akirk commented Mar 31, 2016

In certain environments like translate.wordpress.org it can make sense to allow some people to only import translations with the status "waiting".

This can be established by creating a new import-waiting permission, as well as adding a dropdown to select the status for imported translations.

Mockup:
glotpress-import-waiting-current

akirk added a commit to akirk/GlotPress that referenced this issue Mar 31, 2016
Add status dropdown to import form.
Allow setting the import status through the form based on the import or import-waiting permission.
Include waiting and fuzzy translations when checking whether to create a new entry.
akirk added a commit to akirk/GlotPress that referenced this issue Mar 31, 2016
Add status dropdown to import form.
Allow setting the import status through the form based on the import or import-waiting permission.
Include waiting and fuzzy translations when checking whether to create a new entry.
Don't refetch all translations if there are none in the first place
@toolstack toolstack added [Type] Enhancement A suggestion for improvement. [Status] In Progress Tracking issues with work in progress labels Mar 31, 2016
@toolstack
Copy link
Contributor

I think the logic is a little backwards on this, import-waiting as you've done it is effectively a negative permission (by having it you lose access to import current) which is the wrong way to do it.

It might make more sense to have two separate rights, which both grant access to the import type, like import-waiting and import-current. A user with each of those rights would be able to import that type of status.

I have a few other comments but they're specific to the PR so I'll add them there.

@ocean90
Copy link
Member

ocean90 commented Mar 31, 2016

This can be established by creating a new import-waiting permission,

Both - import-waiting and import - permissions will prevent existing validators to upload translations. How can we prevent that? Can we map both to approve? Note that the current permission system doesn't support removing a permission (via the UI), so it wouldn't be possible to have a user which can approve but not import.

@toolstack
Copy link
Contributor

There are a couple things we could do to handle the current users (and by the way I'm not convinced this is a change that belongs in core yet):

  • As part of the upgrade process, add import permissions to anyone that currently has approve.
  • Add in to the permissions check for import, import-waiting and approve

@ocean90 ocean90 modified the milestone: 2.1 Apr 1, 2016
akirk added a commit to akirk/GlotPress that referenced this issue Apr 9, 2016
Add status dropdown to import form.
Allow setting the import status through the form based on the import or import-waiting permission.
Include waiting and fuzzy translations when checking whether to create a new entry.
Don't refetch all translations if there are none in the first place
akirk added a commit to akirk/GlotPress that referenced this issue Apr 27, 2016
akirk added a commit to akirk/GlotPress that referenced this issue Apr 28, 2016
akirk added a commit to akirk/GlotPress that referenced this issue Apr 28, 2016
yoavf pushed a commit to Automattic/GlotPress-WP that referenced this issue May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants