-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to translations to be imported with status waiting #377
Comments
Add status dropdown to import form. Allow setting the import status through the form based on the import or import-waiting permission. Include waiting and fuzzy translations when checking whether to create a new entry.
Add status dropdown to import form. Allow setting the import status through the form based on the import or import-waiting permission. Include waiting and fuzzy translations when checking whether to create a new entry. Don't refetch all translations if there are none in the first place
I think the logic is a little backwards on this, It might make more sense to have two separate rights, which both grant access to the import type, like I have a few other comments but they're specific to the PR so I'll add them there. |
Both - |
There are a couple things we could do to handle the current users (and by the way I'm not convinced this is a change that belongs in core yet):
|
Add status dropdown to import form. Allow setting the import status through the form based on the import or import-waiting permission. Include waiting and fuzzy translations when checking whether to create a new entry. Don't refetch all translations if there are none in the first place
In certain environments like translate.wordpress.org it can make sense to allow some people to only import translations with the status "waiting".
This can be established by creating a new
import-waiting
permission, as well as adding a dropdown to select the status for imported translations.Mockup:
The text was updated successfully, but these errors were encountered: