Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined $entry variable when updating a glossary entry #366

Closed
ocean90 opened this issue Mar 23, 2016 · 0 comments
Closed

Undefined $entry variable when updating a glossary entry #366

ocean90 opened this issue Mar 23, 2016 · 0 comments
Assignees
@ocean90
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone
2.0

Comments

@ocean90
Copy link
Member

ocean90 commented Mar 23, 2016

The glossary-entry-row template requires an $entry variable set. The variable doesn't exist when updating an entry, see https://github.com/GlotPress/GlotPress-WP/blob/4f4cf956bfc39bb8fce3904cb94f2ae08b2f67a0/gp-includes/routes/glossary-entry.php#L136

$ge should probably be renamed to $entry.
@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Mar 23, 2016
@ocean90 ocean90 mentioned this issue Mar 23, 2016
Merged
@ocean90 ocean90 added this to the 2.0 milestone Mar 23, 2016
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Mar 23, 2016
@ocean90 ocean90 self-assigned this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocean90 ocean90

Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@ocean90