Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspend cache invalidation during original imports #332

Closed
ocean90 opened this issue Mar 11, 2016 · 0 comments
Closed

Suspend cache invalidation during original imports #332

ocean90 opened this issue Mar 11, 2016 · 0 comments
Assignees
@ocean90
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone
2.0

Comments

@ocean90
Copy link
Member

ocean90 commented Mar 11, 2016

This happens with enabled translation propagation:
suspend

We shouldn't delete the translation set cache in GP_Translation->copy_into_sets() every time. Only once after the import is done.

https://github.com/GlotPress/GlotPress-WP/blob/a74092bad4d25f0bcc874c3c877a00ffefcc457e/gp-includes/things/translation.php#L344
@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Mar 11, 2016
@ocean90 ocean90 self-assigned this Mar 11, 2016
@ocean90 ocean90 added this to the 1.1 milestone Mar 11, 2016
ocean90 added a commit that referenced this issue Mar 11, 2016
@ocean90
Suspend cache invalidation during original imports.
e9ba7b4 
Instead, clear the cache for translation sets after the import is done.

Fixes #332.
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Mar 11, 2016
This was referenced Mar 11, 2016
Merged
Open
ocean90 added a commit that referenced this issue Mar 11, 2016
@ocean90
Suspend cache invalidation during original imports.
a1ce704 
Instead, clear the cache for translation sets after the import is done.

Fixes #332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocean90 ocean90

Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@ocean90