Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated assets/img/glotpress-logo.png #327

Merged
merged 1 commit into from
Mar 12, 2016

Conversation

PeterDaveHello
Copy link
Contributor

This is not a code level PR, this is a lossless recompression via Google's zopfli, which can save the bandwidth to transfer the logo.

Save 2965 bytes, almost 40% of the origin size (4746 -> 1781 bytes)

Origin commands:
$ zopflipng --iterations=1000 --lossy_transparent --splitting=3 --filters=01234mepb -y glotpress-logo.png glotpress-logo.png

@toolstack
Copy link
Contributor

That logo file is no longer used in the code, it's just there for historical reasons.

@ocean90 what do you think about just deleting it?

@PeterDaveHello
Copy link
Contributor Author

Oops, if it was not used anymore, let's delete it.

@ocean90
Copy link
Member

ocean90 commented Mar 11, 2016

I'm fine with removing the logo.

@toolstack
Copy link
Contributor

@PeterDaveHello can you update your PR to delete the file instead? Thanks.

@PeterDaveHello
Copy link
Contributor Author

Sure.

@PeterDaveHello PeterDaveHello changed the title Recompress glotpress-logo.png losslessly Remove deprecated assets/img/glotpress-logo.png Mar 12, 2016
@PeterDaveHello
Copy link
Contributor Author

Updated!

@ocean90 ocean90 added this to the 1.1 milestone Mar 12, 2016
@ocean90 ocean90 self-assigned this Mar 12, 2016
@ocean90 ocean90 merged commit dc043fc into GlotPress:develop Mar 12, 2016
@PeterDaveHello PeterDaveHello deleted the logo-zopfli-recompress branch March 12, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants