-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations: Store user_id of validator/approver #293
Comments
Seems like a good idea. |
Should this be a more general field which contains the user ID of the last edit? This would allow us to use it for rejects too.
Should this be a meta field attached to the translation or a new table column in the database? |
I think it should be the id of the user that made the last status change to the translation. I'd tend to add this as a new column only to avoid another query. |
I'd like to move this forward - @ocean90 are you ok with an additional column? |
@yoavf See the related discussion on Slack. We have to make sure that all current workflows can be handled with a new column. Maybe #209 (history/log/notes per translation) is a better idea for this? |
FWIW I agree with @toolstack. AFAIK, in a normal flow, every translation requires the validation step so it seems integral to the translation record entity. |
Related discussion on Slack: https://wordpress.slack.com/archives/glotpress/p1464715578000943 @yoavf Let's try the additional column approach. |
This would allow us to show the name of a validator in the "meta" sidebar like
![approver](https://cloud.githubusercontent.com/assets/617637/13206020/196e8c58-d8f6-11e5-8dc8-d36a43cedb93.png)
The text was updated successfully, but these errors were encountered: