Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Store user_id of validator/approver #293

Closed
ocean90 opened this issue Feb 21, 2016 · 7 comments
Closed

Translations: Store user_id of validator/approver #293

ocean90 opened this issue Feb 21, 2016 · 7 comments
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Feb 21, 2016

This would allow us to show the name of a validator in the "meta" sidebar like
approver

@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Feb 21, 2016
@toolstack
Copy link
Contributor

Seems like a good idea.

@ocean90 ocean90 modified the milestone: 1.1 Feb 25, 2016
@ocean90 ocean90 self-assigned this Feb 25, 2016
@ocean90
Copy link
Member Author

ocean90 commented Mar 10, 2016

Should this be a more general field which contains the user ID of the last edit? This would allow us to use it for rejects too.

Translated by: User 1
if status = current
   Approved by: last_edited_user
elseif status = rejected
   Rejected by: last_edited_user

Should this be a meta field attached to the translation or a new table column in the database?

@toolstack
Copy link
Contributor

I think it should be the id of the user that made the last status change to the translation.

I'd tend to add this as a new column only to avoid another query.

@toolstack toolstack modified the milestones: Future, 1.1 Mar 15, 2016
@ocean90 ocean90 modified the milestones: Future, 2.1 Apr 1, 2016
@yoavf
Copy link
Member

yoavf commented May 29, 2016

I'd like to move this forward - @ocean90 are you ok with an additional column?

@ocean90
Copy link
Member Author

ocean90 commented May 30, 2016

@yoavf See the related discussion on Slack. We have to make sure that all current workflows can be handled with a new column.

Maybe #209 (history/log/notes per translation) is a better idea for this?

@mhsdef
Copy link

mhsdef commented May 31, 2016

FWIW I agree with @toolstack. AFAIK, in a normal flow, every translation requires the validation step so it seems integral to the translation record entity.

@ocean90
Copy link
Member Author

ocean90 commented May 31, 2016

Related discussion on Slack: https://wordpress.slack.com/archives/glotpress/p1464715578000943

@yoavf Let's try the additional column approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants