Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled "Beautify On Save" will still trigger beautification dialogue #455

Closed
tusing opened this issue Jul 12, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@tusing
Copy link

tusing commented Jul 12, 2015

Disabling beautify on save doesn't work. The "Beautifying" dialogue (which doesn't seem to adhere to the user theme at all) still pops up. This seems to persist after removing atom-beautify from the command line and reinstalling it.

@Glavin001 Glavin001 added the bug label Jul 13, 2015
@Glavin001
Copy link
Owner

Please run Atom command Atom Beautify - Help Debug Editor which includes some usable debugging information that I will need.

As of #308 , the Beautify On Save option has been removed in place of language specific beautify on save options. See this related issue for more details: #405 (comment)
This was a while ago, so I am going to assume that this is not the problem and that you are not attempting to use the old Beautify On Save option. Please let me know which language you are working with: the lang in Language Config - <lang> - Beautify On Save option.

Another issue that comes to mind when reading this is #327, "loading dialog pops on save, even when not beautifying". This has since been resolved and no other users have had any more reports of this occurring. However, if there is an existing bug and it is occurring again then I would like to resolve this ASAP and it is high priority. Many users use Beautify On Save functionality and I do not want to impede their usual workflow.

Both of the above possibly related issues have been resolved, so it is likely something new. Once I have more information that will help me reproduce this bug then I can work on a fix.

@Glavin001 Glavin001 self-assigned this Jul 13, 2015
@Glavin001 Glavin001 changed the title [BUG] Beautify On Save broken Disabled "Beautify On Save" will still trigger beautification dialogue Jul 13, 2015
@Glavin001 Glavin001 added this to the v0.29.0 milestone Jul 13, 2015
@Glavin001 Glavin001 modified the milestones: v0.30.0, v0.29.0 Mar 30, 2016
@Glavin001 Glavin001 modified the milestones: v0.30.0, v0.31.0 Jun 22, 2017
@stale
Copy link

stale bot commented Nov 4, 2017

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 4, 2017
@stale stale bot closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants