Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php is not necessary #263

Merged
merged 1 commit into from
Apr 5, 2015
Merged

php is not necessary #263

merged 1 commit into from
Apr 5, 2015
+1 −1

Conversation

georgemincof
Copy link
Contributor

No description provided.

@jaswrks
Copy link

jaswrks commented Apr 5, 2015

Just wanted to say that I agree with this PR.

The php prefix is actually causing problems for me (on OS X), because php refers to /usr/bin/php instead of to /usr/bin/env php (i.e., /usr/local/bin/php).

In any case, the leading php being removed leaves this up to the shebang line in php-cs-fixer, which is what should occur IMO :-)

@Glavin001
Copy link
Owner

Looks good to me. Thanks!

Glavin001 added a commit that referenced this pull request Apr 5, 2015
@Glavin001
Merge pull request #263 from MGAio/patch-1
6654bc3 
php prefix is not necessary for php-cs-fixer
@Glavin001 Glavin001 merged commit 6654bc3 into Glavin001:master Apr 5, 2015
@Glavin001
Copy link
Owner

Published to v0.23.2

@georgemincof georgemincof deleted the patch-1 branch April 5, 2015 14:54
@Glavin001 Glavin001 mentioned this pull request Apr 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgemincof @jaswrks @Glavin001