Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSComb support #209

Closed
alem0lars opened this issue Feb 9, 2015 · 12 comments
Closed

CSSComb support #209

alem0lars opened this issue Feb 9, 2015 · 12 comments
Assignees
Milestone

Comments

@alem0lars
Copy link

The current CSS beautifier is not really flexible.

I think CSScomb would be much better since it's a more configurable and flexible beautifier.

We can take a look at our people implemented it in atom, here there are some examples:

  • atom-css-comb
  • css-comb

Thanks

@Glavin001 Glavin001 self-assigned this Feb 9, 2015
@Glavin001 Glavin001 added this to the v1.0.0 milestone Feb 9, 2015
@prettydiff
Copy link
Collaborator

@alem0lars the links provided for CSScomb resolve to 404 pages. Is there some other location for CSScomb?

@alem0lars
Copy link
Author

Yes: Github page

@danielbayley
Copy link
Contributor

+1

@Glavin001 Glavin001 modified the milestones: v0.26.0, v0.25.0 May 3, 2015
@Glavin001
Copy link
Owner

Links to existing Atom packages:

@Glavin001
Copy link
Owner

CSScomb will be included in v0.26.0

To switch from JS Beautify (CSS) or Pretty Diff (SCSS/Sass/LESS) to using CSScomb, you will go into Atom Beautify package settings and find the option for Language Config - <Your Desired Language: CSS, etc> - Default Beautifier and select CSScomb.

CSScomb looks for a .csscomb.json file in your Atom's first project directory. If it does not find one, or if importing it fails, it will fallback to csscomb predefined configuration.

@Glavin001
Copy link
Owner

Published to v0.26.0

@alem0lars
Copy link
Author

Thanks very much 😄

@DanielJoyce
Copy link
Contributor

Buggy, doesn't seem to reload .csscomb.json sometimes.

@wyudong
Copy link

wyudong commented Sep 9, 2016

It must restart Atom to let custom configPath to take effect.

@Glavin001
Copy link
Owner

@DanielJoyce : The current implementation caches .csscomb.json and would require reloading Atom to clear cache: https://github.com/Glavin001/atom-beautify/pull/623/files#diff-da1ec4e677f98ecd91454c8d30ff68eaR33
Using .csscomb.cson does not appear to cache and should work without reloading: https://github.com/Glavin001/atom-beautify/pull/623/files#diff-da1ec4e677f98ecd91454c8d30ff68eaR31
Please submit a Pull Request implementing anything fixes you might have.

@ghost
Copy link

ghost commented Dec 15, 2016

CSScomb looks for a .csscomb.json file in your Atom's first project directory.

Just wondering, why doesn't it look for the file in the project we're actually in?

@Glavin001
Copy link
Owner

@robsonenke it was not implemented like that in the Pull Request #623. Feel free to submit a Pull Request to fix it! Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants