Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meteor support #183

Closed
Francescu opened this issue Jan 9, 2015 · 10 comments
Closed

Add meteor support #183

Francescu opened this issue Jan 9, 2015 · 10 comments

Comments

@Francescu
Copy link

Hi,

I installed the meteor-api package and it adds Javascript (Meteor) as a language.

atom-beautify tells me Unsupported language for grammar 'JavaScript (Meteor)'.

@Glavin001 Glavin001 added this to the v1.0.0 milestone Jan 10, 2015
@Glavin001 Glavin001 self-assigned this Jan 10, 2015
@awatson1978
Copy link

Oh my gosh, if you could add the Meteor styleguide to atom-beautify, that would be amazing. I've been working on the meteor-api package, and would be more than happy to help debug any Meteor support.

Meteor styleguide is below...
https://github.com/meteor/meteor/wiki/Meteor-Style-Guide

@Glavin001
Copy link
Owner

@prettydiff is this a language that you'd consider supporting?

@prettydiff
Copy link
Collaborator

Yep, I will add Meteor style guide to the jspetty style guide options.

prettydiff/prettydiff#58

@Glavin001
Copy link
Owner

@prettydiff has added support so this is now high priority.

@Glavin001
Copy link
Owner

@Francescu / @awatson1978 , please provide a simple example file that is not beautified. I am adding tests and once I have that example file I will publish 👍.

@Glavin001
Copy link
Owner

Meteor support should come when #282 is released.

@Glavin001 Glavin001 modified the milestones: v1.0.0, v1.1.0, v0.25.0, v0.26.0 May 1, 2015
@Glavin001
Copy link
Owner

Published to v0.25.0

This is a very big release with lots of internal changes and (hopefully) no breaking changes. Please let me know if you are experiencing any unusual behaviour / breaking changes after updating. Thank you.

@Glavin001 Glavin001 modified the milestones: v0.26.0, v0.25.0 May 3, 2015
@Glavin001
Copy link
Owner

I may have to add the grammar JavaScript (Meteor) to a language. Is Meteor simply JavaScript? If you change the grammar for your file from JavaScript (Meteor) to JavaScript and then beautify, does that work?

@Glavin001 Glavin001 modified the milestones: v0.25.0, v0.26.0 May 3, 2015
@awatson1978
Copy link

Yeah, it's just JavaScript. A specific api implemented in javascript, but same grammar and syntax. I'm away from my computer this weekend, but have this on my todo list. Will try getting to it early this week!

@Glavin001
Copy link
Owner

Excellent, thanks! Let me know wherever I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants