Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript-formatter #1638

Closed
epelc opened this issue May 2, 2017 · 4 comments
Closed

Update typescript-formatter #1638

epelc opened this issue May 2, 2017 · 4 comments
Assignees
@Glavin001
Labels
published update-dependency
Milestone
v0.30.6

Comments

@epelc
Copy link

epelc commented May 2, 2017

Description

The latest version of typescript-formatter is 5.1.3 but atom-beautify is using 2.3.0. This causes issues if you try to run tsfmt on a project that also uses atom-beautify(ie subtle differences).

See the changelog for differences https://github.com/vvakame/typescript-formatter/blob/master/CHANGELOG.md
@Vic-Dev
Copy link

Vic-Dev commented Jun 23, 2017

Yes please update

@effervescentia
Copy link

Please update this, we rely heavily on typescript and atom for development

@Vic-Dev Vic-Dev mentioned this issue Jun 23, 2017
Closed
6 tasks
@Glavin001
Copy link
Owner

A Pull Request is how this is going to get done. I just received one 3 hours ago: #1740
It is currently failing to pass TypeScript tests. Once it works as expected, I can merge and publish.

@kamontat kamontat mentioned this issue Jul 15, 2017
Merged
6 tasks
@Glavin001 Glavin001 self-assigned this Oct 30, 2017
@Glavin001
Copy link
Owner

Published to v0.30.6

@Glavin001 Glavin001 added this to the v0.35.6 milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glavin001 Glavin001

Labels
published update-dependency
Projects
None yet
Milestone
v0.30.6
Development

Successfully merging a pull request may close this issue.

Update typescript formatter Vic-Dev/atom-beautify
5 participants
@prettydiff @Glavin001 @effervescentia @epelc @Vic-Dev