-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Custom configuration is ignored and overridden #16
Comments
Removed https://github.com/donaldpipowitch/atom-beautify/blob/45352dd90591826e72054536f671b9eb074a9843/lib/atom-beautify.js#L154-L156 because it was incorrectly merging all of the options together. for (key in externalOptions) {
_.merge(collectedConfig, externalOptions[key]);
} Important: This will result in previous usage of nested configurations no longer merging, such as using the |
I just noticed that the You can even see it in the screenshot in previous comments, The afflicting code is the function cleanOptions(data, types) {
nopt.clean(data, types);
return data;
} Which really just calls https://github.com/npm/nopt |
I am going to temporarily comment out the lines that use Currently working on Handlebars support (see #13) and commenting it out makes everything work: Before: {{#if}}
{{#each}}
{{#if}}
content
{{/if}}
{{#if}}
content
{{/if}}
{{/each}}
{{/if}} After (with {{#if}}
{{#each}}
{{#if}}
content
{{/if}}
{{#if}}
content
{{/if}}
{{/each}}
{{/if}} |
|
Notice that in the first log, under
html
theindent_size
is6
. However, later on it is overridden toindent_size: 6
.The text was updated successfully, but these errors were encountered: