Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other Data Support #14

Closed
4 tasks done
Glavin001 opened this issue Jun 12, 2014 · 7 comments · Fixed by #23
Closed
4 tasks done

Other Data Support #14

Glavin001 opened this issue Jun 12, 2014 · 7 comments · Fixed by #23

Comments

@Glavin001
Copy link
Owner

@Glavin001
Copy link
Owner Author

@donaldpipowitch @karolyi what do you think about support for SQL and JSON, and using pretty-data? Is it a direction we want to go?

@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

jsbeautifier should be able to parse json files, is there something similar JS-based for SQL?

having the foundation laid down, it shouldn't be a big issue.

@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

(btw JSON should be able to beautifiy with JSON.stringify)

@Glavin001
Copy link
Owner Author

(btw JSON should be able to beautifiy with JSON.stringify)

Yeah, I usually use JSON.stringify, good point.

Looks like that is how they implement it, too: https://github.com/vkiryukhin/pretty-data/blob/master/pretty-data.js#L135-L144

is there something similar JS-based for SQL

pretty-data supports SQL: https://github.com/vkiryukhin/pretty-data/blob/master/pretty-data.js#L181-L288

@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

Well then, waiting for your PR ;)

@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

If you want to be the hero of the day, implement the beautifier for strip-json-comments too :)

@Glavin001
Copy link
Owner Author

I'll see what I can do later tonight ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants