Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet beautification via puppet-lint. #131

Closed
dougborg opened this issue Oct 27, 2014 · 10 comments
Closed

Add Puppet beautification via puppet-lint. #131

dougborg opened this issue Oct 27, 2014 · 10 comments

Comments

@dougborg
Copy link

It should be fairly easy to add beautification of puppet (*.pp) files using puppet-lint (http://puppet-lint.com).

@Glavin001 Glavin001 self-assigned this Oct 28, 2014
@Glavin001
Copy link
Owner

That does look fairly easy! Would you be up for submitting a Pull Request?
I have created a special class for handling the cases of Command-Line Interface beautifiers, such as this one: https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/cli-beautify.coffee
There are many beautifiers extending it: https://github.com/Glavin001/atom-beautify/tree/master/lib/langs
Ruby for instance: https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/ruby-beautify.coffee

I hope this helps and that you are up for contributing! Thanks :).

@dougborg
Copy link
Author

I am up for submitting a pull request, and thanks for the pointers! I'll take a closer look at it tonight if I get a chance.

@ghost
Copy link

ghost commented Mar 31, 2015

@dougborg or @Glavin001 - have any of you taken a crack at this yet?

@Glavin001
Copy link
Owner

I have not.

I am hoping after my exams (next few weeks) that I will be able to find time to greatly improve Atom Beautify.

@dougborg
Copy link
Author

I had looked at it a bit ages ago, but then got caught up in other things. I may be able to take another look this weekend.

@ghost
Copy link

ghost commented Apr 1, 2015

@Glavin001 @dougborg - Thanks for the updates!

@Glavin001 Glavin001 added this to the v0.27.0 milestone May 5, 2015
@Glavin001
Copy link
Owner

The new internal API ( #282 ) for adding beautifiers and languages make it much quicker and easier to add support. If anyone is feeling up for submitting a pull request, they are always welcome. And feel free to ask any questions. I am still working on documentation, so if there are questions then I'll make sure to keep track of them for documenting later.

@Glavin001 Glavin001 modified the milestones: v0.28.0, v0.27.0 May 5, 2015
@Glavin001 Glavin001 modified the milestones: v0.29.0, v0.28.0 Jun 6, 2015
@Glavin001
Copy link
Owner

See #300 (comment) for how to add a new language and/or beautifier.

Update: I will be maintaining this documentation on adding languages and beautifiers: https://github.com/Glavin001/atom-beautify/blob/master/docs/add-languages-and-beautifiers.md

@rmaika
Copy link

rmaika commented Jun 17, 2015

Thanks for creating those docs, @Glavin001. I would love to have a beautifier for developing Puppet code. I think I'll give writing a beautifier a shot when I have a bit of free time to knock it out.

@Glavin001
Copy link
Owner

Great! Let me know if you have any questions 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants