Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brace-style options for pretty-diff #1076

Closed
2 of 4 tasks
amorino opened this issue Jul 19, 2016 · 5 comments
Closed
2 of 4 tasks

brace-style options for pretty-diff #1076

amorino opened this issue Jul 19, 2016 · 5 comments

Comments

@amorino
Copy link

amorino commented Jul 19, 2016

Description

Customize the brace-style of the beautification, currently using pretty diff, it collapses.

Input

import { render } from "react-dom";

Output

import {render} from "react-dom";

Expected Results

import { render } from "react-dom";

Steps to Reproduce

  1. Add code to Atom editor
  2. Run command Atom Beautify: Beautify Editor on a .js using ES6
  3. This beautified code does not look right!

Debug

Here is a link to the debug.md Gist: https://gist.github.com/anonymous/4780ecc468ba3be2c1d27b48f1307a15

Checklist

  • I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
  • I have reloaded (or restarted) Atom to ensure it is not a caching issue
  • Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
    so I know this is not a duplicate issue
  • Generated debugging information and added link for debug.md Gist to this issue
@Glavin001 Glavin001 added this to the v0.30.0 milestone Jul 19, 2016
@prettydiff
Copy link
Collaborator

Pretty Diff has an option for this: bracepadding. I do not see a similar option in the Atom Beautify settings.

@Glavin001
Copy link
Owner

We should add Pretty Diff support for brace-style option (see

) and convert it to bracepadding option internally.

@carlesnunez
Copy link

Any news here?

@Glavin001
Copy link
Owner

Glavin001 commented Apr 20, 2017

#1193 added bracepadding support via Atom-Beautify option named space_in_paren.

It closed #1157 and should have also closed this.

@Glavin001
Copy link
Owner

Published to v0.29.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants