Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raster.icrop #659

Open
vschaffn opened this issue Mar 4, 2025 · 0 comments · May be fixed by #660
Open

Fix raster.icrop #659

vschaffn opened this issue Mar 4, 2025 · 0 comments · May be fixed by #660

Comments

@vschaffn
Copy link
Contributor

vschaffn commented Mar 4, 2025

Currently raster.icrop uses a bounding box whose inputs are not in the same order as other objects used with icrop. Changing the order of the bounding box would be simpler and would avoid errors when using icrop.
In addition, icrop currently uses crop to cut out the raster. This means that the input bounding box is converted several times (pixel -> coordinates then coordinates-> pixel). There should be a way to make it more optimal.
@vschaffn vschaffn added enhancement Feature improvement or request and removed enhancement Feature improvement or request labels Mar 4, 2025
@vschaffn vschaffn linked a pull request Mar 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimizing raster.icrop vschaffn/geoutils
1 participant
@vschaffn