Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introducing a new branch related property with name track-merge-message #3302

Closed
HHobeck opened this issue Dec 8, 2022 · 1 comment · Fixed by #3392
Closed
Labels
Milestone

Comments

@HHobeck
Copy link
Contributor

HHobeck commented Dec 8, 2022

Is your improvement request related to a problem? Please describe.
In the discussion of issue #3052 ([Bug] track-merge-changes produces unexpected result [..]) I came up with the idea of introducing a new branch related property with the name track-merge-message (see #3052 (comment)).

Detailed Description

Consider we have a main branch and a release/1.0.0 branch and merge changes from release/1.0.0 to the main branch. Then this commit message will be interpreted when executing the tool on the main branch as a next version 1.0.0. I would like to make it configurable so you are able to change this behavior with track-merge-message e.g. on the main branch to false. This gives you the next version 0.0.1 instead of 1.0.0.

Context

This property fits like all other branch related properties into the configuration system and gives the user the possibility to control the behavior of whether the merge commit message will be interpreted as a next version or not. Today the message will be always interpreted as a next version which can be in some workflow scenarios not what you want.

Possible Implementation

I think the implementation is not hard because we only need to check this property in the class who implements this aspect of the VersionStrategy.

@HHobeck HHobeck added this to the 6.x milestone Feb 8, 2023
@HHobeck HHobeck changed the title [Improvement] Introducing a new branch related property with name track-merge-message [Feature] Introducing a new branch related property with name track-merge-message Feb 8, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.1 Mar 2, 2023
@arturcic
Copy link
Member

arturcic commented Mar 2, 2023

🎉 This issue has been resolved in version 6.0.0-beta.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants