Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Update Homebrew package #2374

Closed
asbjornu opened this issue Jul 31, 2020 · 11 comments
Closed

[Improvement] Update Homebrew package #2374

asbjornu opened this issue Jul 31, 2020 · 11 comments

Comments

@asbjornu
Copy link
Member

asbjornu commented Jul 31, 2020

GitVersion on Homebrew is out of date and we should implement a process to ensure that it's kept up to date.

Detailed Description

The current version of GitVersion on Homebrew requires Mono, since .NET Core is not yet available in Homebrew. .NET Core was unsuccessfully attempted to be added in Homebrew/homebrew-core#3691. As a self-contained executable is not permitted (see Homebrew/homebrew-core#53092), someone (most likely one of us) needs to submit a .NET Core formula first and then submit a new version of GitVersion dependent on the .NET Core formula. See dotnet/sdk#4600 for more information.

Context

Having an up to date GitVersion formula in Homebrew will make it easier to use GitVersion on (most importantly) macOS and Linux.

Possible Implementation

  1. We should take a look at the rejected formula in WIP: Initial dotnet formula Homebrew/homebrew-core#3691 and tweak it to match the latest version of .NET Core.
  2. Once the .NET Core formula is accepted, we should submit an upgraded GitVersion formula dependent on the .NET Core formula.
  3. Every time we create a release in GitVersion, we can bump the version and SHA in the GitVersion formula and submit it as a pull request towards the homebrew-core repository with the create-pull-request action. This will ensure that the GitVersion formula in Homebrew is kept up to date.
@asbjornu
Copy link
Member Author

asbjornu commented Aug 2, 2020

The current status is that .NET Core is impossible to build from source unless you have access to Microsoft's internal NuGet feeds. So in practice, you need to be hired by Microsoft in order to build .NET Core. 🤦 See dotnet/sdk#11795 for details.

@asbjornu
Copy link
Member Author

With Homebrew/homebrew-core#60929 merged, we can finally go ahead and do this. 🎉

@arturcic
Copy link
Member

@asbjornu great job on that PR. I followed the progress there, that was an amazing work

@arturcic
Copy link
Member

If I can help with anything let me know

@arturcic
Copy link
Member

Do you think we can automate the homebrew PR creation as part of the release flow? ( Maybe using the github cmdline tool gh )

@MikeMcQuaid
Copy link

@arturcic Yup! Check out brew bump-formula-pr, https://github.com/dawidd6/action-homebrew-bump-formula and https://github.com/mislav/bump-homebrew-formula-action.

@asbjornu
Copy link
Member Author

Thanks for the input, @MikeMcQuaid! I've started work on doing an initial bump of the GitVersion formula that now depends on dotnet instead of mono. I'll let you know once the PR is created.

@arturcic
Copy link
Member

@arturcic Yup! Check out brew bump-formula-pr, https://github.com/dawidd6/action-homebrew-bump-formula and https://github.com/mislav/bump-homebrew-formula-action.

Thank you, then I think we can automate that

@asbjornu
Copy link
Member Author

Here it is: Homebrew/homebrew-core#62817.

@asbjornu
Copy link
Member Author

And now Homebrew/homebrew-core#62817 is merged, so I'm closing this. The brew bump-formula-pr automation can be tracked in another issue, I think.

@arturcic
Copy link
Member

The brew bump-formula-pr automation can be tracked in another issue, I think.

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants