Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core GitVersion -showvariable exception #1469

Closed
snovak7 opened this issue Sep 6, 2018 · 5 comments
Closed

.NET Core GitVersion -showvariable exception #1469

snovak7 opened this issue Sep 6, 2018 · 5 comments

Comments

@snovak7
Copy link
Contributor

snovak7 commented Sep 6, 2018

Hello, I have installed nuget package for netstandard: This version has an error when I want to make -showvariable, any showvariable, it returns:

System.NotImplementedException: The method or operation is not implemented.
   at GitVersion.VersionVariables.ContainsKey(String variable) in C:\projects\gitversion\src\GitVersionCore\OutputVariables\VersionVariables.cs:line 196
   at GitVersion.VersionVariables.TryGetValue(String variable, String& variableValue) in C:\projects\gitversion\src\GitVersionCore\OutputVariables\VersionVariables.cs:line 181
   at GitVersion.SpecifiedArgumentRunner.Run(Arguments arguments, IFileSystem fileSystem)
   at GitVersion.Program.VerifyArgumentsAndRun()

Without options, I get a valid JSON output.

@dazinator
Copy link
Member

Yup the .NET Core implementation of this command was omitted in #1269
It just needs implementing really. I'll mark this as up for grabs.

@snovak7
Copy link
Contributor Author

snovak7 commented Oct 13, 2018

Well I just used whats in the NETDESKTOP and it worked. You should add NETSTANDARD option there aswell. And here's the patch.
patch_1469.txt

This was made on master branch so Version 4

@snovak7
Copy link
Contributor Author

snovak7 commented Oct 16, 2018

@dazinator or should I prepare PR?

@arturcic
Copy link
Member

it's up for grabs, feel free to prepare a PR

@dazinator
Copy link
Member

Nice one @snovak7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants