-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The same version generated twice #1255
Comments
Have you tried with |
Sorry, it's 2019, the bug was reported in 2017. I no longer remember the details, but GitVersion was not working reliably enough for us and in the end we have written our own task to calculate version numbers according to our own needs and strategy and it's working since then in most of our projects. I think it would be good to drop the need to maintain our own solution, but it's probably too late now. |
I'm sorry to hear that, @dpurge and I apologize for the absence. Whenever you feel like taking a look at GitVersion again, I hope it's reached a more stable state and suits your needs well. I'll close this and welcome you back whenever the opportunity presents itself. Godspeed! |
I have stumbled on smth that looks like a bug to me .
Given this configuration (abbreviated from my unit tests for gitversion.yml):
I am getting this in my unit test log:
Note that in step 0003 and 0006 gitversion has returned the same semantic version: 5.0.0-beta.1
And then it continues the count, duplicating beta.2 and so on.
I see two problems with the observed behaviour:
There is also an inconsistency: in step 0001 it started to count beta from 0 (which surprised me), but after the RC in step 0006 it started to count beta from 1.
In addition (I do not show this in the log to keep things simpler) after +semver:fix even though the patch number was increased, the beta suffix did not restart the count, which IMHO is not the right behaviour.
I am testing against version:
4.0.0-beta.12+1315.Branch.master.Sha.9c70946f68973b3b31b2861913c247fbe6c3f0ec
I would expect GitVersion to figure out that it needs to increase the version as every 5.0.0-beta would be lower than 5.0.0-rc.1, so given my configuration it should bump the patch number and re-start the beta count. Using this logic, the expected version would be: 5.0.1-beta.1
Any tips on how to get the configuration right will be appreciated, as I need to come up with working configuration for a team adopting this tool. I have only started to learn about gitversion; maybe I am not using it correctly?
The text was updated successfully, but these errors were encountered: