You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new UpdateVersionProperties section in the 4.0 GitVersionTask.targets file is using a different value for FileVersion than the UpdateAssemblyInfo task.
Well, it would be easy to submit a quick PR that fixed this one thing, since it would just be a matter updating the two targets files to have the correct value.
The larger refactoring being considered in #1242 would also end up taking this into account, but maybe it would be worth fixing this up in the existing code first?
The new
UpdateVersionProperties
section in the 4.0GitVersionTask.targets
file is using a different value forFileVersion
than theUpdateAssemblyInfo
task.UpdateAssemblyInfo
is using AssemblySemFileVer.UpdateVersionProperties
is using $(GitVersion_MajorMinorPatch).$(GitVersion_CommitsSinceVersionSource) in both versions of the targets file.To maintain consistency with previous behavior, I think
UpdateVersionProperties
should be changed to matchUpdateAssemblyInfo
.I'd be happy to submit a PR if you agree that this should be changed.
The text was updated successfully, but these errors were encountered: