Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/updateassemblyinfo should add fully qualified attribute names #1214

Closed
tpluscode opened this issue May 15, 2017 · 2 comments
Closed

/updateassemblyinfo should add fully qualified attribute names #1214

tpluscode opened this issue May 15, 2017 · 2 comments
Labels

Comments

@tpluscode
Copy link

I've just noticed that when I run gitversion /updateassemblyinfo it only adds attributes using only its class name which fails build if using System.Reflection is missing.

I think that the safest path is to always add fully qualified type names which will work regardless of the usings.

@asbjornu
Copy link
Member

@tpluscode: Agreed. I believe it's best practice for generated code to use the global:: prefix and fully qualified names. Pull requests are welcome! 😄

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2019
@stale stale bot closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants