Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add issue/pr filter/sort #287

Closed
Sherlouk opened this issue Sep 5, 2017 · 10 comments
Closed

Add issue/pr filter/sort #287

Sherlouk opened this issue Sep 5, 2017 · 10 comments
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@Sherlouk
Copy link
Member

Sherlouk commented Sep 5, 2017

Should add a way to filter and sort the issues and pull requests after entering into the repository view.

  • Filter open/closed/all
  • Sort date asc/desc
@Sherlouk Sherlouk added the 🆕 feature request A feature being requested to be added, not yet approved label Sep 5, 2017
@rnystrom
Copy link
Member

rnystrom commented Sep 5, 2017

Woo! Great minds think alike 😄. Brainstorming how the UI for this might work. I'm thinking a new cell that sits at the top of the PR list that has search/filter/sort controls or something.

@rnystrom rnystrom added the mid label Sep 22, 2017
@rnystrom
Copy link
Member

Blocked by #336 atm

@joerocca
Copy link
Member

Thought this may be a cool UI for this?
Custom presentation like this and possibly use pageboy with authors, issues, projects, milestones, assignees, and sort view controllers. Or may be better to keep it one page.

img_0020 jpg

@rnystrom
Copy link
Member

rnystrom commented Oct 24, 2017

Here’s my suggestion:

Working on new filters interactions
https://dribbble.com/shots/2097072-Working-on-new-filters-interactions

  • Drop down indicator that there are options
  • Each filter has a cell with a label and then bubble options
  • Options can be single or multi select
  • Once you select a few things and close, totally refresh contents
    • this will help with paging bugs. Do not just filter existing models
  • Button to quickly clear

Defaults should mirror GitHub too, eg open issues, not all.

Also, we can use the binding SC to make this easy af.

Sent with GitHawk

@Sherlouk
Copy link
Member Author

Sherlouk commented Dec 3, 2017

img_0765

See linked issue (1008), but I quite like the idea of a custom keyboard for this - fairly easy to add (just a keyboard view with a horizontal collection view!)

Moving discussion into one issue for easier tracking, good candidate for upcoming release me thinks!

@rnystrom
Copy link
Member

rnystrom commented Dec 3, 2017

Part of me wonders if we should start super simple:

  • Add the default is:open to the bar
  • Change to the v3 API
  • Map different keywords to v3 params
  • Fetch as text changes
  • List PRs API doesn't have documented search fields like Issues. Maybe they are undocumented? I've seen a few of those

@Sherlouk
Copy link
Member Author

Sherlouk commented Dec 3, 2017

FWIW you can search for things like milestones etc via v4 API, it's just done as part of the search stirng e.g. label:bug (see how the web search bar fills when you change search options)

@jbraem
Copy link

jbraem commented Jun 27, 2018

Apologies if this has already been brought up, but I just started with Githawk and would love the ability to limit the inbox to issues & PRs that I'm assigned to and/or mentioned in.

At my job our team uses issues heavily across several projects, and as-is most of the activity I get in the inbox isn't relevant to me personally.

(Tangentially related to #292)

@rnystrom
Copy link
Member

rnystrom commented Jul 9, 2018

@jbraem that's an interesting idea! Different from this issue (this is filtering issues/PRs within a repo). Would love another issue open to track that! Could be a useful setting or something.

@jbraem
Copy link

jbraem commented Jul 17, 2018

Thanks @rnystrom. I added it in #1924

Keep up the good work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

4 participants