Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Mute and more buttons don't work when a thread is read #2657

Open
mesqueeb opened this issue Feb 28, 2019 · 9 comments · May be fixed by #2705
Open

Mute and more buttons don't work when a thread is read #2657

mesqueeb opened this issue Feb 28, 2019 · 9 comments · May be fixed by #2705
Labels
🐛 bug Unintended behaviour within the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase

Comments

@mesqueeb
Copy link

mesqueeb commented Feb 28, 2019

GitHawk Upload by mesqueeb

@BasThomas BasThomas added the 🐛 bug Unintended behaviour within the app label Feb 28, 2019
@RJ-Clegg
Copy link

RJ-Clegg commented Feb 28, 2019

I'll take a look at this if no one has started on it yet

@BasThomas BasThomas added the ✨ good first issue An issue suitable for someone looking to get familiar with the codebase label Feb 28, 2019
@mesqueeb
Copy link
Author

mesqueeb commented Mar 11, 2019

@RJ-Clegg How it going?

  • It's often I mark a thread as "read" by mistake, try to mark it "unread" again, but can't because of this bug.
  • Another case I often have is I mark a thread "read", then try to turn off notifications, but cannot do that because of this bug.

I feel a looooot of people would be really excited for your fix! 💘🎉

@albertbass86
Copy link

Hi, is there an update on this?

Sent with GitHawk

@mesqueeb
Copy link
Author

I think not yet, it's still bugged in my version 😔very annoying but it's a free app so I won't complain? 😁

Sent with GitHawk

@albertbass86
Copy link

Well I ask because I would like to contribute to the project and seemed like this would be a good issue to work on. However it looks like @RJ-Clegg was working on it?

I don’t understand how issue assignment works here.

@BasThomas
Copy link
Collaborator

It’s a bit tricky as you can’t assign tickets to outside contributors. Feel free to pick it up, @albertbass86, and let us know if we can help!

Sent with GitHawk

@albertbass86
Copy link

Cool! I was wondering if it was fine for me to just pick it. Will give it a try. Thank you 👌

Sent with GitHawk

@albertbass86
Copy link

Hi again, I have a simple solution but it feels a bit like a workaround.

It involves just adding a hitTest to the notification cell so touches are captured by the buttons instead of the cell. I feel like there is a different solution but I do not have enough context of the app to be sure.

Do you want me to create a PR and see @BasThomas or do you have pointers towards a different approach?

@BasThomas
Copy link
Collaborator

Feel free to open a pull request, and we can continue from there.

I think it already uses a hit test rather than being able to tap the buttons in the cell?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@albertbass86 @mesqueeb @BasThomas @RJ-Clegg and others