Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal or vertical ribbon #1513

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jan 17, 2021

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

X = [cos.(0:0.1:20) sin.(0:0.1:20)]
D= [DataFrame(x=0:0.1:20, y=X[:,j], ymin=X[:,j].-0.5, ymax=X[:,j].+0.5, f="$f") for (j,f) in enumerate(["cos","sin"])]

p1 = plot(vcat(D...), x=:x, y=:y, ymin=:ymin, ymax=:ymax, color=:f, Geom.line, Geom.ribbon, alpha=[0.6])
p2 = plot(vcat(D...), x=:y, y=:x, xmin=:ymin, xmax=:ymax, color=:f, Geom.path, Geom.ribbon)
hstack(p1, p2)

Ribbon

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #1513 (6bae95a) into master (eef6074) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   89.72%   89.82%   +0.09%     
==========================================
  Files          39       39              
  Lines        4613     4637      +24     
==========================================
+ Hits         4139     4165      +26     
+ Misses        474      472       -2     
Impacted Files Coverage Δ
src/geom/ribbon.jl 100.00% <100.00%> (ø)
src/scale.jl 95.63% <0.00%> (+0.48%) ⬆️
src/aesthetics.jl 79.69% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef6074...6bae95a. Read the comment docs.

@Mattriks Mattriks merged commit 21d8674 into GiovineItalia:master Jan 18, 2021
@humphreylee
Copy link

Excellent. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geom.ribbon bounded left and right <- Feature Request
3 participants