Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with DataFrames 0.22 on Julia 1.5 #1499

Merged
merged 5 commits into from
Nov 21, 2020

Conversation

nalimilan
Copy link
Contributor

No description provided.

@rikhuijzer
Copy link
Contributor

rikhuijzer commented Nov 18, 2020

Note that if you run the CI after upgrading CategoricalArrays so that DataFrames goes to 0.22, one test will fail (https://github.com/GiovineItalia/Gadfly.jl/runs/1417459612).

@nalimilan can you trigger CI again?

@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #1499 (10050de) into master (3a6da5a) will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
+ Coverage   88.94%   89.71%   +0.77%     
==========================================
  Files          39       39              
  Lines        4395     4601     +206     
==========================================
+ Hits         3909     4128     +219     
+ Misses        486      473      -13     
Impacted Files Coverage Δ
src/ticks.jl 91.09% <0.00%> (-0.28%) ⬇️
src/shapes.jl 100.00% <0.00%> (ø)
src/geom/line.jl 100.00% <0.00%> (ø)
src/geom/point.jl 100.00% <0.00%> (ø)
src/geom/ribbon.jl 100.00% <0.00%> (ø)
src/geom/violin.jl 100.00% <0.00%> (ø)
src/geom/boxplot.jl 100.00% <0.00%> (ø)
src/geom/polygon.jl 100.00% <0.00%> (ø)
src/dataframes.jl 97.61% <0.00%> (+0.05%) ⬆️
src/geom/label.jl 96.33% <0.00%> (+0.06%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6da5a...17f1759. Read the comment docs.

@nalimilan
Copy link
Contributor Author

nalimilan commented Nov 18, 2020

Thanks. I've added a fix for that test. But CI still uses DataFrames 0.21.8 (not sure why since I've just updated RDatasets to allow 0.22, and CSV doesn't depend on DataFrames).

EDIT: Got it, that because we need #1496 to support RDatasets 0.7 first. I don't know why I can't find a mention of that conflict now in the logs. Where are the missing lines showing the packages used during testing?

@rikhuijzer
Copy link
Contributor

That other PR is mostly working on fixing the failing Julia 1.0 (LTS). What happens if you bump RDatasets? (Note that I can't do it for you because I'm not an official maintainer here at Gadfly. I just saw something at my PR which might help your PR out.)

nalimilan referenced this pull request in JuliaStats/RDatasets.jl Nov 18, 2020
@nalimilan
Copy link
Contributor Author

Tests now pass with DataFrames 0.22 on Julia 1.5.

@bjarthur bjarthur changed the title Support DataFrames 0.22 Fix tests with DataFrames 0.22 on Julia 1.5 Nov 21, 2020
@bjarthur bjarthur merged commit 8954fe8 into GiovineItalia:master Nov 21, 2020
@nalimilan nalimilan deleted the patch-1 branch November 22, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants