-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests with DataFrames 0.22 on Julia 1.5 #1499
Conversation
Note that if you run the CI after upgrading CategoricalArrays so that DataFrames goes to 0.22, one test will fail (https://github.com/GiovineItalia/Gadfly.jl/runs/1417459612). @nalimilan can you trigger CI again? |
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
==========================================
+ Coverage 88.94% 89.71% +0.77%
==========================================
Files 39 39
Lines 4395 4601 +206
==========================================
+ Hits 3909 4128 +219
+ Misses 486 473 -13
Continue to review full report at Codecov.
|
Thanks. I've added a fix for that test. But CI still uses DataFrames 0.21.8 (not sure why since I've just updated RDatasets to allow 0.22, and CSV doesn't depend on DataFrames). EDIT: Got it, that because we need #1496 to support RDatasets 0.7 first. I don't know why I can't find a mention of that conflict now in the logs. Where are the missing lines showing the packages used during testing? |
That other PR is mostly working on fixing the failing Julia 1.0 (LTS). What happens if you bump RDatasets? (Note that I can't do it for you because I'm not an official maintainer here at Gadfly. I just saw something at my PR which might help your PR out.) |
Tests now pass with DataFrames 0.22 on Julia 1.5. |
No description provided.