Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom_ribbon: replace nan separator by missing #1478

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

Mattriks
Copy link
Member

  • I've run the regression tests (involving Geom.ribbon)
  • I've built the docs and confirmed these changes don't cause new errors

This PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #1478 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1478   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files          39       39           
  Lines        4398     4398           
=======================================
  Hits         3922     3922           
  Misses        476      476           
Impacted Files Coverage Δ
src/geom/ribbon.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b00e9...dc51c7e. Read the comment docs.

@Mattriks Mattriks merged commit ff15191 into GiovineItalia:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InexactError when using integers in Geom.ribbon
2 participants