Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more Discrete Scale documentation #1370

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

Mattriks
Copy link
Member

  • I've updated the documentation
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

@Mattriks
Copy link
Member Author

Gadfly's Compose compat obviously needs to be bumped,. Would it also make things easier if common packages (e.g. Colors etc) have the same compats?

@bjarthur
Copy link
Member

bjarthur commented Dec 21, 2019

herein lies the problem with the polling (instead of interrupt style) mechanism used by CompatHelper. ideally the tagging of Compose should have triggered an immediate notification to Gadfly that it's compat section is out of date. but Github permissions don't allow actions to post PRs to other repos. so all CompatHelper can do is poll periodically. Gadfly and Compose are currently set to do so midnight on sunday, or whenever an issue is opened or re-opened.

@bjarthur
Copy link
Member

just add another commit which updates Compose in compat.

@tlnagy
Copy link
Member

tlnagy commented Dec 21, 2019

Gadfly and Compose are currently set to do so midnight on sunday, or whenever an issue is opened or re-opened.

Why can't we just poll daily? It would be nice to batch the updates more than that, but it's not really a hassle.

@bjarthur
Copy link
Member

we could, i just figured it's a load on the servers that isn't warranted, despite being free.

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #1370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          38       38           
  Lines        3961     3961           
=======================================
  Hits         3587     3587           
  Misses        374      374

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3465a6f...d3bcd00. Read the comment docs.

@Mattriks Mattriks force-pushed the scale_discrete_docs branch from 3e58d2f to d3bcd00 Compare December 22, 2019 19:43
@Mattriks
Copy link
Member Author

Rebased and ready to merge.

@bjarthur bjarthur merged commit ee4b5ae into GiovineItalia:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants